Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Ink #5815

Merged
merged 23 commits into from
Nov 14, 2022
Merged

Add support for Ink #5815

merged 23 commits into from
Nov 14, 2022

Conversation

benthicmaw
Copy link
Contributor

@benthicmaw benthicmaw commented Mar 3, 2022

Adding support for Inkle's Ink scripting language, used for writing Interactive Fiction.

Description

  • Added TextMate format language grammar.
  • Added samples (MIT licensed), obtained from the official Inky repo here.

Checklist:

@benthicmaw benthicmaw requested a review from a team as a code owner March 3, 2022 14:18
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really don't need this many samples, especially when most of the content of them is a comment.

Please reduce the number of samples to two or three that are most representative of the general usage of the language.

You probably want to add a color too else the language will fallback to a very boring grey

@lildude
Copy link
Member

lildude commented Nov 14, 2022

I've cleaned up the samples and resolved all issues - sorry for the noise - so this is now ready for merging as the popularity looks good now.

@lildude lildude merged commit 1adde0d into github-linguist:master Nov 14, 2022
@benthicmaw
Copy link
Contributor Author

Great, thanks a lot @lildude!

@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants