-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Browserslist #5099
Add support for Browserslist #5099
Conversation
Adding Browserslist config highlighting is important because it is default way to specify target browsers in Autoprefixer and Babel and it is already used in 350K public repositories. |
Usage checks out (I happen to be familiar with the format, so I'm skipping the usual sample harvest routine). Just a small nit to correct and we should be good to go. 👍 |
@voskresla You might want to set $ git config --global core.ignorecase false Or add to your [core]
ignorecase = false The |
) |
LGTM. 👍 @lildude, I say we . |
@wspwebben We don't judge formats on their deprecation– or recommendation-status, only their real-world distribution. Discouraging the use of a filename won't change the fact there are over a million files on GitHub using that particular format and filename. |
That's why we should keep support for that format in configs, so syntax highlight would still work for these files, but there's no need to keep that format as an example in samples |
There is. The |
Got it, thank you for clarification :D |
No problem! 😉 That's also the reason we prefer "real-world" samples instead of just "Hello, world" examples, BTW:—they need to be an accurate rendition of the sort of files Linguist will encounter in-the-wild after it starts indexing the new language. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This won't go live on GitHub.com until a new release is made which I won't be able to do until mid-to-late January at the earliest.
Description
This PR add support for Browserslist configs.
Syntax highlighting based on https://github.com/browserslist/browserslist-vscode.
cc @ai
Checklist:
.browserslistrc
: ~360,347 resultsbrowserslist
: ~826,669 resultsbrowserslist/browserslist-vscode