Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Mustache templates as a separate type (modelled on Latte) #4915

Merged
merged 9 commits into from
Sep 1, 2020
Merged

Added Mustache templates as a separate type (modelled on Latte) #4915

merged 9 commits into from
Sep 1, 2020

Conversation

yourpropertyexpert
Copy link
Contributor

Description

Added a single extra language type - Mustache, which previous versions of linguist (mis-)classified as HTML+Django.

Checklist:

  • I am associating a language with a new file extension.

    • The new extension is used in hundreds of repositories on GitHub.com
    • I have included a real-world usage sample for all extensions added in this PR:
      • Sample source(s):
        • Added to the /samples directory in a new directory called Mustache
      • Sample license(s): Apache 2, but given I wrote them for this submission, I'm happy for the github / linguist project to assign a different licence
  • I am adding a new language.

  • I am fixing a misclassified language

    • Only to the extent that the language's normal extension was incorrectly identified with another group
  • I am adding new or changing current functionality

    • I have added or updated the tests for the new or changed functionality.
      • To the extent that I've added the new samples to the vendor README, which may have been the wrong thing to do

@lildude lildude requested review from pchaigno and Alhadis July 22, 2020 15:40
@stale
Copy link

stale bot commented Aug 22, 2020

This pull request has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this pull request was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions.

@stale stale bot added the Stale label Aug 22, 2020
@yourpropertyexpert
Copy link
Contributor Author

Alas, seems to have been overlooked.

@stale stale bot removed the Stale label Aug 23, 2020
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lildude lildude merged commit da27b51 into github-linguist:master Sep 1, 2020
sambacha pushed a commit to freight-trust/linguist that referenced this pull request Sep 4, 2020
…ub-linguist#4915)

* Update languages.yml

* Create csvrow.mustache

* Rename samples/csvrow.mustache to samples/Mustache/csvrow.mustache

* Added sample file

* Create pupilinfoblock.mustache

* Create showallusers.mustache

* Updated Vendor README with Mustache

Co-authored-by: Colin Seymour <colin@github.com>
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants