Use GitHub Actions for CI and Prepare to use GitHub Package Registry #4600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so we can start using GitHub Package Registry.
Alhadis
reviewed
Aug 11, 2019
Alhadis
approved these changes
Aug 11, 2019
Alhadis
reviewed
Aug 12, 2019
Alhadis
reviewed
Aug 12, 2019
|
All feedback implemented @Alhadis. Thanks 🙇. Wanna take another peek? And feed free to suggest any other changes that have been on your mind; we've not touch the CI side of things for many many years. |
Alhadis
reviewed
Aug 12, 2019
|
Only one other thing I've picked up on, but other than that, 👍 from me! |
Alhadis
reviewed
Aug 12, 2019
|
I should also give a nod to the AWS Lambda that powers the badge - https://github.com/CultureHQ/github-actions-badge/blob/master/README.md |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It's been an exciting few months for GitHub, especially last week with the introduction of GitHub Actions adding support for CI/CD.
This PR switches Linguist from using Travis for CI to GitHub Actions 🎉 . Wanna see it in action? https://github.com/github/linguist/runs/190621762
At the same time, I'm adding support for publishing packages to the GitHub Package Registry so we can use it from the next release onwards. One day we'll also be able to take advantage of GitHub Actions to create and publish the gem automatically too, but can't right now due to reasons I can't go into.
Checklist removed as it doesn't apply.