-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GitHub Actions for CI and Prepare to use GitHub Package Registry #4600
Conversation
This is so we can start using GitHub Package Registry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First half of this PR reads like an advert, but otherwise LGTM. 👍
All feedback implemented @Alhadis. Thanks 🙇. Wanna take another peek? And feed free to suggest any other changes that have been on your mind; we've not touch the CI side of things for many many years. |
Only one other thing I've picked up on, but other than that, 👍 from me! |
I should also give a nod to the AWS Lambda that powers the badge - https://github.com/CultureHQ/github-actions-badge/blob/master/README.md |
Description
It's been an exciting few months for GitHub, especially last week with the introduction of GitHub Actions adding support for CI/CD.
This PR switches Linguist from using Travis for CI to GitHub Actions 🎉 . Wanna see it in action? https://github.com/github/linguist/runs/190621762
At the same time, I'm adding support for publishing packages to the GitHub Package Registry so we can use it from the next release onwards. One day we'll also be able to take advantage of GitHub Actions to create and publish the gem automatically too, but can't right now due to reasons I can't go into.
Checklist removed as it doesn't apply.