-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace the Bro language with Zeek #4516
Conversation
Bro was officially renamed to Zeek. The primary file extension will be .zeek, but .bro is also still supported. The external grammar definition, "bro-sublime", is now "zeek-sublime". The later has updates that reflect the name change and some further improvements. Also adds samples of the Zeek language.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the neat pull request! LGTM!
Any chance you could also add a sample file for .bro
while you're at it?
It's identical to the .zeek sample.
@pchaigno Thanks, I added a sample |
Thanks. Having duplicate sample files is indeed very likely to skew the Bayesian classifier. If you can find a |
Ok, added a different |
Perfect! Thanks! |
Bro was officially renamed to Zeek in this announcement. The primary file extension will be
.zeek
, but.bro
is also still supported. In either case, the language should now be identified as "Zeek" instead of "Bro". Themaster
branch of the main Zeek repository has already converted to using the.zeek
extension.The external grammar definition, "bro-sublime", is now "zeek-sublime".
The later has updates that reflect the name change and some further
improvements. Lightshow comparisons:
Real-world sample OLD source.bro
Real-world sample NEW source.zeek
Real-world sample source file
Real-world sample license
Contrived sample OLD source.bro
Contrived sample NEW source.zeek
Contrived sample source file
Contrived sample license
Both samples are included in this commit.
Checklist:
The new extension is used in hundreds of repositories on GitHub.com
.bro
extension is used within the order of a hundred repos just counting what's listed on our public, user-submitted package repository.I have included a real-world usage sample for all extensions added in this PR:
I have included a change to the heuristics to distinguish my language from others using the same extension.