Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the Bro language with Zeek #4516

Merged
merged 3 commits into from
May 10, 2019

Conversation

jsiwek
Copy link
Contributor

@jsiwek jsiwek commented May 1, 2019

Bro was officially renamed to Zeek in this announcement. The primary file extension will be
.zeek, but .bro is also still supported. In either case, the language should now be identified as "Zeek" instead of "Bro". The master branch of the main Zeek repository has already converted to using the .zeek extension.

The external grammar definition, "bro-sublime", is now "zeek-sublime".
The later has updates that reflect the name change and some further
improvements. Lightshow comparisons:

Real-world sample OLD source.bro
Real-world sample NEW source.zeek
Real-world sample source file
Real-world sample license

Contrived sample OLD source.bro
Contrived sample NEW source.zeek
Contrived sample source file
Contrived sample license

Both samples are included in this commit.

Checklist:

  • I am REPLACING an existing language name, adding a new file extension for it, and updating its grammar submodule all at once
    • The new extension is used in hundreds of repositories on GitHub.com

    • I have included a real-world usage sample for all extensions added in this PR:

      • Sample sources + licenses listed above.
    • I have included a change to the heuristics to distinguish my language from others using the same extension.

      • N/A

Bro was officially renamed to Zeek.  The primary file extension will be
.zeek, but .bro is also still supported.

The external grammar definition, "bro-sublime", is now "zeek-sublime".
The later has updates that reflect the name change and some further
improvements.

Also adds samples of the Zeek language.
Copy link
Contributor

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the neat pull request! LGTM!

Any chance you could also add a sample file for .bro while you're at it?

It's identical to the .zeek sample.
@jsiwek
Copy link
Contributor Author

jsiwek commented May 1, 2019

@pchaigno Thanks, I added a sample .bro, but it's just identical to one of the .zeek samples. Let me know if a unique file (or even symlink) is preferred.

@pchaigno
Copy link
Contributor

pchaigno commented May 2, 2019

Thanks. Having duplicate sample files is indeed very likely to skew the Bayesian classifier. If you can find a .bro file under permissive license that would be better. If you can't it's not a big issue, we can just continue without .bro samples.

@jsiwek
Copy link
Contributor Author

jsiwek commented May 2, 2019

Ok, added a different .bro file. Source file and license.

@pchaigno
Copy link
Contributor

pchaigno commented May 2, 2019

Perfect! Thanks!

@pchaigno pchaigno requested a review from lildude May 2, 2019 07:23
@lildude lildude merged commit 92bccde into github-linguist:master May 10, 2019
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants