-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Golang color #4331
Improve Golang color #4331
Conversation
Going by Golang's style-guide, I'd say Gopher Blue Since this is endorsed by the Go project's official branding, I don't see too much ire being raised over this change... nonetheless, @alassanecoly should be aware of #4326 (which eventuated rather recently),. Changing the colours of well-known programming languages should be done with caution and only when project styleguides warrant it... |
You're right. I directly took the color from the Gopher mascot. So does the actual color should be changed to |
Stick to their official blue |
😹 I got you |
/cc @snormore and @jredville who contributed to Linguist on Go aspects before and might have an opinion. |
The color conflicts with Dockerfile's. @alassanecoly Could you check whether changing Dockerfile's color to the second color associated with the language fixes the issue? |
Should I open a new PR to fix the issue ? |
Did you check that changing Dockerfile to its second color fixes build failures? |
@pchaigno Build fixed 🙌 |
@lildude @Alhadis Do you think it's okay if we change the Dockerfile color to be able to change the Golang one? The new color for Dockerfile is selected with the same rationale as the old one. |
Erh, I just noticed how similar Go's new colour is to Perl's... :| I know I'm colour-blind, but those colours look really, really similar to me, and with the recent uproar from the Rust community over the sudden colour change, I'm not sure this will sit well with many... |
Yeah, I'm also a little hesitant changing the colours for a prominent language like Go after the Rust furore, especially as this PR, at a quick glimpse, almost looks like we're switching the two colours around. The current Go colour has also been in use for nearly 5 years - this change will be noticed. The question is how much of a stink is this likely to cause? Maybe not much, as in both cases we're using official brand colours, and I think the proximity to Perl won't be too much of a problem either as the current colour is already close to several others and I don't think many peeps will be mixing the two, though you never know. |
Probably not nearly as much as the Rust colour change caused. We have Go's branding as a sound justification for the colour change, and googling "Go Lang" in Google Images reveals a swarth of cyan-coloured mascots. It's actually harder to justify the current colour, really. |
Should we raise the issue at https://groups.google.com/forum/#!forum/golang-nuts for this as well? @lildude - I think @Alhadis' improvement makes a lot of sense and might also help color-blind peeps (cf #3394). Should we move it to a separate issue and ping the appropriate Githubbers? |
That might be best. We've now got the Crystal peeps upset too 😢
No need. We've got an issue open on the main GitHub repo already, and it includes a suggestion like @Alhadis's. I'll give it another nudge as it hasn't been touched in a while. |
Posted an issue at golang-nuts on december 5th: https://groups.google.com/forum/#!topic/golang-nuts/Xr_x9REPC-c. 98 views but nobody replied 😓 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Giving this a "LGTM", because the change is relatively uncontroversial (given it falls in line with Go's official styleguide).
22 days later, still no response. I guess we're either right to change this or they simply don't care. 😅 |
Or nobody of your interest is reading the mailing list ;) |
Heh. That's true, in a way. 😉 But out of the 111 views the topic's received, none of the readers felt strongly enough to comment. Hopefully that's indicative of the Go community at large. 🤞 If not, well, we can use Go's official styleguide as a defence. It's possible we're being overly cautious in light of the Rust backlash. Rust's colour was changed on purely arbitrary grounds, Go's colour change is not. |
Nudging @lildude. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still no comments from the wider community, but as both languages are inline with branding guidelines for each, lets go ahead with this.
This change is great, thanks for updating Go to display with the correct color. Can't wait for it go live. 🎉 |
Don't want to be a trouble-maker but I was used for years to this color and I would have preferred it to stay unchanged. |
I came here from Reddit discussions about the color change. It's a shame that the community at large doesn't know about this. I had no idea that the color changing and style changes like that new white border between the colors were done publicly through PRs like this. I'm a new Go dev, and I love the new color. It makes much more sense. I also like the new white border. It was so subtle a change that I never actually noticed it, but it works great. If I would have known about this PR I would have chimed in with my opinion, as I'm sure many other devs would have, so that it wouldn't have stagnated like that with weeks of inactivity. |
We did try to reach out to the community (see above) but it's not always obvious how to do that. |
I'm the perpetrator of #4319...and I approve this change. |
I think this is a good example of how to do this right. @pmaddams reverted the change when the community stated they didn't like it. Here, the Go community seems to like this change. If the communities are happy, we're probably doing something right. All's well that ends well? |
In #3815, I wanted to update the Racket color to match the blue color used in the logo. Unfortunately, Go was very close in the colorspace. In #4331, Go was changed to a lighter blue. Now, with a minor tweak, the Racket color can be successfully updated from `#22228f` to `#3c5caa`. This won't turn out like the #4319 (Rust) debacle for the following reasons: - The blue color is official, not just a random opinion. - We are going from a dark and not easily visible shade of blue to a lighter shade of the same color. - Racket is not as popular as Rust, so an army of Reddit users will not show up armed with negative emojis. Of course, if a Racket developer shows up and explains why this is a disaster, it will be easy enough to revert. But I think a nicer color will help Racket, an underappreciated Lisp dialect, look more attractive.
The actual color of Go doesn't looks like the color of the official Gopher mascot.
#5FC9D8
fits more to the mascot which is a bright and joyful blue turquoise.Also the actual deep blue color (
#375EAB
) looks a lot like PHP (#4F5D95
) & Python (#3572A5
) ones.