Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Dockerfile a programming language #4169

Merged
merged 2 commits into from
Jun 22, 2018

Conversation

lildude
Copy link
Member

@lildude lildude commented Jun 21, 2018

Description

Dockerfiles have grown hugely in popularity since first added to Linguist and are essentially scripts. To quote https://docs.docker.com/engine/reference/builder/:

A Dockerfile is a text document that contains all the commands a user could call on the command line to assemble an image.

... which is essentially what a shell script it. This PR flips the categorisation from data to programming so these files are now included in the language stats.

Checklist:

  • I am adding new or changing current functionality
    • I have added or updated the tests for the new or changed functionality.

No need for new or different tests as we're just changing how a language is classified.

TODO:

  • Find a colour that is representative, but doesn't conflict - gonna be tough as Docker ❤️ blue, like everyone else.

Fixes #3628

@lildude
Copy link
Member Author

lildude commented Jun 21, 2018

Wow! First try at picking the colour and it's a 🎯, courtesy of https://brandcolors.net/b/docker 🎉

Copy link
Contributor

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lildude lildude merged commit 4e239d9 into master Jun 22, 2018
@lildude lildude deleted the lildude/dockerfile-as-programming branch June 22, 2018 05:57
@pchaigno pchaigno mentioned this pull request Dec 1, 2018
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dockerfile showing as shell in language stats bar
2 participants