Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language alias for the Windows file system #4285

Merged

Conversation

pchaigno
Copy link
Contributor

@pchaigno pchaigno commented Oct 3, 2018

With this pull request, languages with a non-Windows compatible name must include an fs_name alias. That alias is used to create the samples and fixtures directories. This change enables repository cloning under Windows.

The F* entry now uses Fstar as the Windows compatible alias.

Fixes #4234.

@lildude:

Please also remind me that I'll need to perform the DB nudge when I make the next release once that PR has been merged so the language rename is picked up in the DB.

Template removed as it doesn't apply.

lib/linguist/languages.yml Show resolved Hide resolved
@pchaigno pchaigno force-pushed the windows-compatible-language-names branch from 0a5d02c to 8efbf94 Compare October 9, 2018 19:52
Languages with a non-Windows compatible name must include an fs_name alias.
That alias is used to create the samples and fixtures directories. This change
enables repository cloning under Windows.

The F* entry now uses Fstar as the Windows compatible alias.
@pchaigno pchaigno force-pushed the windows-compatible-language-names branch from 8efbf94 to b4bc0b5 Compare October 9, 2018 19:57
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and nice idea to implement a new option. I don't need to update the aliases in the DB now 😁

@pchaigno pchaigno merged commit be00240 into github-linguist:master Oct 15, 2018
@pchaigno pchaigno deleted the windows-compatible-language-names branch October 15, 2018 15:20
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot clone repo on Windows
4 participants