Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Associate node interpreter to TypeScript #4261

Merged

Conversation

pchaigno
Copy link
Contributor

@pchaigno pchaigno commented Sep 1, 2018

This pull request adds the node interpreter to TypeScript to help with the recognition of TypeScript files with a .js extension.

Description

The node interpreter is already associated to JavaScript, but thanks to #4099, subsequent strategies (e.g., the Extension Strategy) can now refine the results and distinguish between TypeScript and JavaScript file.

Fixes #4112.

Checklist:

The node interpreter is already associated to JavaScript, but thanks
to 54ae7e7, subsequent strategies (e.g., the Extension Strategy) can
now refine the results and distinguish between TypeScript and
JavaScript file.
@Alhadis
Copy link
Collaborator

Alhadis commented Sep 1, 2018

In about five years, we'll be stuffing Perl scripts and Python runtimes directly inside JavaScript source code, and expecting some magic genie's compiler to cope with it all... 😝

@pchaigno
Copy link
Contributor Author

pchaigno commented Sep 1, 2018

...and still writing the kernel on which all this stuff runs in C.

@Alhadis
Copy link
Collaborator

Alhadis commented Sep 1, 2018

I foresee this to be the future of kernel programming, according to current trends:

Figure 1

That edit also wouldn't suck so much if I still had access to Adobe software. 😓

@pchaigno
Copy link
Contributor Author

pchaigno commented Sep 1, 2018

Who want to write kernel code in Go??! I doubt we're even gonna write large pieces of kernel code in Rust before a long time...

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pchaigno pchaigno merged commit aa28619 into github-linguist:master Sep 3, 2018
@pchaigno pchaigno deleted the typescript-node-interpreter branch September 3, 2018 09:12
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript file (.ts) misidentified as JavaScript
3 participants