Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript repo beeing recognized as Javascript #4923

Closed
rafatrace opened this issue Jul 10, 2020 · 6 comments
Closed

Typescript repo beeing recognized as Javascript #4923

rafatrace opened this issue Jul 10, 2020 · 6 comments
Labels

Comments

@rafatrace
Copy link

Problem Description

Could it be because of the .json files? Still, it should show 1% Typescript at least

URL of the affected repository:

https://github.com/rafmst/propor

Last modified on:

2019-07-10

Expected language:

Typescript

Detected language:

Javascript

@lildude
Copy link
Member

lildude commented Jul 10, 2020

Could it be because of the .json files?

Nope. It's because of the shebang:

#!/usr/bin/env node

Linguist considers node as an interpreter for Javascript, not Typescript:

https://github.com/github/linguist/blob/775b07d40c04ef6e0051a541886a8f1e30a892f4/lib/linguist/languages.yml#L2564-L2569

For Typescript, you'd need to either use deno or ts-node:

https://github.com/github/linguist/blob/775b07d40c04ef6e0051a541886a8f1e30a892f4/lib/linguist/languages.yml#L5595-L5602

@rafatrace
Copy link
Author

That explains it, I will try to fix it like you suggested. Thanks for the help, have a nice weekend 😁

@pchaigno
Copy link
Contributor

@lildude I associated the node interpreter with TypeScript in #4261. When did we remove that?

@lildude
Copy link
Member

lildude commented Jul 13, 2020

When @Alhadis merged #4470 😁

The OP of the PR states:

UPDATE: This PR's been updated to remove node from TypeScript's interpreters list as well, following conversation between @pchaigno and @grant. Merging this PR will now also fix #4469.

@stale
Copy link

stale bot commented Aug 16, 2020

This issue has been automatically marked as stale because it has not had activity in a long time. If this issue is still relevant and should remain open, please reply with a short explanation (e.g. "I have checked the code and this issue is still relevant because ___."). Thank you for your contributions.

@stale stale bot added the Stale label Aug 16, 2020
@stale
Copy link

stale bot commented Aug 31, 2020

This issue has been automatically closed because it has not had activity in a long time. Please feel free to reopen it or create a new issue.

@stale stale bot closed this as completed Aug 31, 2020
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants