Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teach Generated about Cargo lock files #4100

Merged
merged 1 commit into from
Apr 15, 2018
Merged

Teach Generated about Cargo lock files #4100

merged 1 commit into from
Apr 15, 2018

Conversation

bb010g
Copy link
Contributor

@bb010g bb010g commented Apr 14, 2018

This PR teaches linguist.generated.Generated about Cargo.lock files.

Resolves #3988.

Checklist:

@@ -0,0 +1,4 @@
[[package]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you replace this sample with one of the "real" samples you linked to in your post?

Copy link
Contributor Author

@bb010g bb010g Apr 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. That one was generated from the hello_cargo example. Sorry, I misunderstood what the PR template meant with the nesting of the sample item. I thought it said that you had to have a sample, and the sources list was more in line with the search verification item.

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR and welcome to Linguist.

@lildude lildude merged commit 5363e04 into github-linguist:master Apr 15, 2018
@bb010g bb010g deleted the cargo-lock branch April 15, 2018 10:07
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Classify Cargo.lock as a generated file
3 participants