Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mingw: support absolute paths without a drive prefix #96

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Commits on Dec 10, 2018

  1. mingw: demonstrate a problem with certain absolute paths

    On Windows, there are several categories of absolute paths. One such
    category starts with a backslash and is implicitly relative to the
    drive associated with the current working directory. Example:
    
    	c:
    	git clone https://github.com/git-for-windows/git \G4W
    
    should clone into C:\G4W.
    
    There is currently a problem with that, in that mingw_mktemp() does not
    expect the _wmktemp() function to prefix the absolute path with the
    drive prefix, and as a consequence, the resulting path does not fit into
    the originally-passed string buffer. The symptom is a "Result too large"
    error.
    
    Reported by Juan Carlos Arevalo Baeza.
    
    Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
    dscho committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    09a73fe View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2018

  1. mingw: allow absolute paths without drive prefix

    When specifying an absolute path without a drive prefix, we convert that
    path internally. Let's make sure that we handle that case properly, too
    ;-)
    
    This fixes the command
    
    	git clone https://github.com/git-for-windows/git \G4W
    
    Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
    dscho committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    33b0cee View commit details
    Browse the repository at this point in the history