Refuse to write to reserved filenames on Windows #496
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the next commit, we want to disallow accessing any path that contains any segment that is equivalent to `NUL`. In particular, we want to disallow accessing `NUL` (e.g. to prevent any repository from being checked out that contains a file called `NUL`, as that is not a valid file name on Windows). However, there are legitimate use cases within Git itself to write to the Null device. As Git is really a Linux project, it does not abstract that idea, though, but instead uses `/dev/null` to describe this intention. So let's side-step the validation _specifically_ in the case that we want to write to (or read from) `/dev/null`, via a dedicated short-cut in the code that skips the call to `validate_win32_path()`. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
There are a couple of reserved names that cannot be file names on Windows, such as `AUX`, `NUL`, etc. For an almost complete list, see https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file If one would try to create a directory named `NUL`, it would actually "succeed", i.e. the call would return success, but nothing would be created. Worse, even adding a file extension to the reserved name does not make it a valid file name. To understand the rationale behind that behavior, see https://devblogs.microsoft.com/oldnewthing/20031022-00/?p=42073 Let's just disallow them all. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
|
/submit |
|
Submitted as pull.496.git.1576965901.gitgitgadget@gmail.com |
|
This branch is now known as |
|
This patch series was integrated into pu via git@19df3e0. |
|
This patch series was integrated into pu via git@29cfef7. |
|
This patch series was integrated into pu via git@56a7159. |
|
This patch series was integrated into pu via git@74542f4. |
|
This patch series was integrated into pu via git@c8499a2. |
|
This patch series was integrated into next via git@5b814fd. |
|
This patch series was integrated into pu via git@b612456. |
|
This patch series was integrated into pu via git@13432fc. |
|
This patch series was integrated into next via git@13432fc. |
|
This patch series was integrated into master via git@13432fc. |
|
Closed via 13432fc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, for historical reasons, file names such as
aux.c,nul.txtare not allowed. Foraux.c, attempts to write such a file will result in an obscure error, fornul.txtthe call will succeed but no such file will appear, ever, instead the effect will be equivalent to writing to/dev/nullon Linux/Unix.Let's help users by refusing to create such files altogether, with an informative error message.