Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a useful default user ident on Windows #45

Closed
wants to merge 3 commits into from
Closed

Provide a useful default user ident on Windows #45

wants to merge 3 commits into from

Commits on Oct 15, 2018

  1. getpwuid(mingw): initialize the structure only once 

    Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
    @dscho
    dscho committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    63373dd View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2018

  1. getpwuid(mingw): provide a better default for the user name 

    We do have the excellent GetUserInfoEx() function to obtain more
detailed information of the current user (if the user is part of a
Windows domain); Let's use it.

Suggested by Lutz Roeder.

To avoid the cost of loading Secur32.dll (even lazily, loading DLLs
takes a non-neglibile amount of time), we use the established technique
to load DLLs only when, and if, needed.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
    @dscho
    dscho committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    8dfccc6 View commit details
    Browse the repository at this point in the history

  2. mingw: use domain information for default email 

    When a user is registered in a Windows domain, it is really easy to
obtain the email address. So let's do that.

Suggested by Lutz Roeder.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
    @dscho
    dscho committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    c53fb4d View commit details
    Browse the repository at this point in the history