Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cvsexportcommit with CR/LF line endings #132

Closed
wants to merge 1 commit into from

Conversation

dscho
Copy link
Member

@dscho dscho commented Feb 24, 2019

When using CVSNT, we need to be prepared to grok CVS output with CR/LF line endings.

While we do not use CVSNT in Git for Windows, this patch made its way into Git's source code via the Git for Windows project (probably because of the ease of GitHub PRs), and we had not a single complaint for over 2 years, so I would consider this patch ready to be included in core Git.

When using cvsnt + msys + git, it seems like the output of cvs status
had \r\n in it, and caused the command to fail.

This fixes that.

Signed-off-by: Dustin Spicuzza <dustin@virtualroadside.com>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho dscho added the ready to submit Has commits that have not been submitted yet label Feb 24, 2019
@dscho
Copy link
Member Author

dscho commented Apr 29, 2019

/submit

@gitgitgadget
Copy link

gitgitgadget bot commented Apr 29, 2019

Submitted as pull.132.git.gitgitgadget@gmail.com

@dscho dscho removed the ready to submit Has commits that have not been submitted yet label Apr 29, 2019
@gitgitgadget
Copy link

gitgitgadget bot commented May 7, 2019

This branch is now known as ds/cvsexportcommit-force-text.

@gitgitgadget
Copy link

gitgitgadget bot commented May 7, 2019

This patch series was integrated into pu via git@7ac9d1f.

@gitgitgadget gitgitgadget bot added the pu label May 7, 2019
@gitgitgadget
Copy link

gitgitgadget bot commented May 8, 2019

This patch series was integrated into pu via git@8deb8fe.

@gitgitgadget
Copy link

gitgitgadget bot commented May 8, 2019

This patch series was integrated into pu via git@3a51cf0.

@gitgitgadget
Copy link

gitgitgadget bot commented May 9, 2019

This patch series was integrated into pu via git@ae02f76.

@gitgitgadget
Copy link

gitgitgadget bot commented May 10, 2019

This patch series was integrated into pu via git@e5d7ff8.

@gitgitgadget
Copy link

gitgitgadget bot commented May 13, 2019

This patch series was integrated into pu via git@2ce2dbc.

@gitgitgadget
Copy link

gitgitgadget bot commented May 13, 2019

This patch series was integrated into pu via git@c36d835.

@gitgitgadget
Copy link

gitgitgadget bot commented May 15, 2019

This patch series was integrated into pu via git@f3cc608.

@gitgitgadget
Copy link

gitgitgadget bot commented May 15, 2019

This patch series was integrated into next via git@9874698.

@gitgitgadget gitgitgadget bot added the next label May 15, 2019
@gitgitgadget
Copy link

gitgitgadget bot commented May 16, 2019

This patch series was integrated into pu via git@8c06492.

@gitgitgadget
Copy link

gitgitgadget bot commented May 19, 2019

This patch series was integrated into pu via git@b5fb62b.

@gitgitgadget
Copy link

gitgitgadget bot commented May 19, 2019

This patch series was integrated into next via git@b5fb62b.

@gitgitgadget
Copy link

gitgitgadget bot commented May 19, 2019

This patch series was integrated into master via git@b5fb62b.

@gitgitgadget gitgitgadget bot added the master label May 19, 2019
@gitgitgadget gitgitgadget bot closed this May 19, 2019
@gitgitgadget
Copy link

gitgitgadget bot commented May 19, 2019

Closed via b5fb62b.

@dscho dscho deleted the cvsexportcommit-crlf branch May 20, 2019 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants