Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do use ALL_CFLAGS in hdr-check #129

Closed
wants to merge 1 commit into from
Closed

Do use ALL_CFLAGS in hdr-check #129

wants to merge 1 commit into from

Conversation

dscho
Copy link
Member

@dscho dscho commented Feb 23, 2019 •
edited
Loading

When I was playing with the Makefile target hdr-check, it looked as if it missed the correct CFLAGS. Without them, on Windows an attempt is made to include syslog.h, which does not make sense at all.

This patch addresses that.

@dscho
hdr-check: make it work on Windows
c13d998 
On Windows, we define a specific set of pre-processor macros, among
other reasons: to avoid including syslog.h (which is not available on
Windows).

The hdr-check target did not use those definitions, resulting in a
failure to include said syslog.h.

To fix that, let's let the hdr-check target make use of ALL_CFLAGS,
which does include the pre-processor macros that would e.g. skip the
conditional block including syslog.h.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho dscho added the ready to submit Has commits that have not been submitted yet label Feb 23, 2019
@dscho
Copy link
Member Author

dscho commented Aug 24, 2019

/submit

@gitgitgadget
Copy link

gitgitgadget bot commented Aug 24, 2019

Submitted as pull.129.git.gitgitgadget@gmail.com

@dscho dscho removed the ready to submit Has commits that have not been submitted yet label Aug 24, 2019
@weekly-digest weekly-digest bot mentioned this pull request Aug 25, 2019
Closed
@gitgitgadget
Copy link

gitgitgadget bot commented Aug 26, 2019

On the Git mailing list, Junio C Hamano wrote (reply to this):

"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
writes:

> When I was playing with the Makefile target hdr-check, it looked as if it
> missed the correct CFLAGS. Without them, on Windows an attempt is made to
> include syslog.h, which does not make sense at all.

Makes sense.

Thanks.

@gitgitgadget
Copy link

gitgitgadget bot commented Aug 26, 2019

This branch is now known as js/honor-cflags-in-hdr-check.

@gitgitgadget
Copy link

gitgitgadget bot commented Aug 26, 2019

This patch series was integrated into pu via git@3dc66a3.

@gitgitgadget gitgitgadget bot added the pu label Aug 26, 2019
@gitgitgadget
Copy link

gitgitgadget bot commented Aug 30, 2019

This patch series was integrated into pu via git@620ba34.

@weekly-digest weekly-digest bot mentioned this pull request Sep 1, 2019
Closed
@gitgitgadget
Copy link

gitgitgadget bot commented Sep 3, 2019

This patch series was integrated into pu via git@eda4733.

@gitgitgadget
Copy link

gitgitgadget bot commented Sep 5, 2019

This patch series was integrated into pu via git@7625976.

@gitgitgadget
Copy link

gitgitgadget bot commented Sep 7, 2019

This patch series was integrated into pu via git@48be1a6.

@weekly-digest weekly-digest bot mentioned this pull request Sep 8, 2019
Closed
@gitgitgadget
Copy link

gitgitgadget bot commented Sep 9, 2019

This patch series was integrated into pu via git@2b8d1ab.

@gitgitgadget
Copy link

gitgitgadget bot commented Sep 9, 2019

This patch series was integrated into next via git@fcd9ee9.

@gitgitgadget gitgitgadget bot added the next label Sep 9, 2019
@weekly-digest weekly-digest bot mentioned this pull request Sep 15, 2019
Closed
@gitgitgadget
Copy link

gitgitgadget bot commented Sep 16, 2019

This patch series was integrated into pu via git@ecf2cf7.

@gitgitgadget
Copy link

gitgitgadget bot commented Sep 17, 2019

This patch series was integrated into pu via git@9e043c3.

@gitgitgadget
Copy link

gitgitgadget bot commented Sep 18, 2019

This patch series was integrated into pu via git@63f7b78.

@gitgitgadget
Copy link

gitgitgadget bot commented Sep 18, 2019

This patch series was integrated into pu via git@101e772.

@weekly-digest weekly-digest bot mentioned this pull request Sep 22, 2019
Closed
@dscho
Copy link
Member Author

dscho commented Oct 27, 2019

My patch was superseded by git@b503a2d.

@dscho dscho closed this Oct 27, 2019
@dscho dscho deleted the fix-hdr-check branch October 27, 2019 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
next pu
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dscho