Skip to content

Commit

Permalink
bisect--helper: convert *_warning char pointers to char arrays.
Browse files Browse the repository at this point in the history
Instead of using a pointer that points at a constant string,
just give name directly to the constant string; this way, we
do not have to allocate a pointer variable in addition to
the string we want to use.

Let's convert `need_bad_and_good_revision_warning` and
`need_bisect_start_warning` char pointers to char arrays.

Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Tanushree Tumane <tanushreetumane@gmail.com>
Signed-off-by: Miriam Rubio <mirucam@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
tanushree27 authored and gitster committed Dec 17, 2019
1 parent 53a06cf commit 7c5cea7
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions builtin/bisect--helper.c
Original file line number Diff line number Diff line change
Expand Up @@ -281,11 +281,11 @@ static int mark_good(const char *refname, const struct object_id *oid,
return 1;
}

static const char *need_bad_and_good_revision_warning =
static const char need_bad_and_good_revision_warning[] =
N_("You need to give me at least one %s and %s revision.\n"
"You can use \"git bisect %s\" and \"git bisect %s\" for that.");

static const char *need_bisect_start_warning =
static const char need_bisect_start_warning[] =
N_("You need to start by \"git bisect start\".\n"
"You then need to give me at least one %s and %s revision.\n"
"You can use \"git bisect %s\" and \"git bisect %s\" for that.");
Expand Down

0 comments on commit 7c5cea7

Please sign in to comment.