Update install.iss: rephrase menu item labels #507
Conversation
• Git Bash Here -> Open Git Bash here • Git GUI Here -> Open Git GUI here Signed-off-by: Ali Mahdavi <ivadham@users.noreply.github.com>
There was a problem hiding this comment.
First things first: ignore the missing dll CI job failures, those are unrelated.
The change does what was discussed in git-for-windows/git#4477 (comment), but that comment accidentally mislead you. These are the feature descriptions within the installer, not the text for the actual context menu entries. That text is defined here and here.
Could I ask you to modify these two lines as well and then ammend the commit and force push?
|
No worries. Thanks for the heads up! |
Ooops. Sorry! |
• Git Bash Here -> Open Git Bash here • Git GUI Here -> Open Git GUI here Signed-off-by: Ali Mahdavi <ivadham@users.noreply.github.com>
|
@rimrul, hey! Although I hate to disturb you by mentioning you, more than two weeks have passed since this "change request", and I have pushed the changes you asked for. It is done in two commits; maybe that's the reason why you have not been notified. Anyway, this PR requires a review. Thanks! |
|
/add release note bug The labels of the File Explorer menu items installed by the Git for Windows installer have been aligned with what is customary ("Git Bash Here" instead of "Open Git Bash Here"). The workflow run was started |
The labels of the File Explorer menu items installed by the Git for Windows installer [have been aligned](#507) with what is customary ("Git Bash Here" instead of "Open Git Bash Here"). Signed-off-by: gitforwindowshelper[bot] <gitforwindowshelper-bot@users.noreply.github.com>
Windows context menu:
P.S. Today I learned what DCO sign-off is. Thank you!