Fix ReadBodyFromRequestAsync disposing ctx.Request.Body

[64J0]

Description

As noticed by @xperiandri, the ReadBodyFromRequestAsync seems to be incorrectly disposing the ctx.Request.Body. I'm adopting the suggestion from @Banashek, to use the leaveOpen = true parameter.

From the docs:

Unless you set the leaveOpen parameter to true, the StreamReader object calls Dispose() on the provided Stream object when StreamReader.Dispose is called.

How to test

TODO

Related issues

• Close Never decalre reader with use on ctx.Request.Body #564

[64J0]

I'm not sure how to test this properly. Ideas are welcome!

[Banashek]

The original bug report was that the body gets disposed.

I would think that asserting the presence of the body post-use would be a good test.

[1eyewonder]

@64J0 Here is a similar type of scenario I had to add over in FsToolkit.ErrorHandling to deal with dispose issues demystifyfp/FsToolkit.ErrorHandling#271 if you were still looking for some unit test ideas

[64J0]

Thanks for the ideas folks! I'll work on it during this week