Add generic matrix format test #904

upsj · 2021-10-11T14:01:57Z

This tests a few generic behaviors for all sparse matrix formats:

SpMV with different strides, numbers of rhs, real-complex behavior and mixed precision
Conversions from and to Csr and Dense
write -> read round-trips
Handling of empty matrices

TODO:

Fix found issues
~~Fix mixed-precision ELL intermediate formats~~
~~Add more specific mixed-precision tests (stricter tolerances)~~
~~Make GKO_ASSERT_MTX_EQ_SPARSITY more strict w.r.t numeric zeros~~
~~Simplify handling of ref/device objects? (remove test_pair)~~
~~Remove fine-grained exception reporting?~~
~~Maybe remove corresponding tests from device-specific kernel tests~~

Fixes #590

yhmtsai · 2021-10-29T12:12:16Z

I did not look into this pr yet.
For conversion, could we have something like pair list?
TestingType = <Csr, Dense>, <Dense, Csr>, <Coo, Csr>...
to denote all possible direction of conversion.
User can also get the all possible conversion from that.

pratikvn

Looks good to me! Really nice work! Should make our testing more robust.

test/matrix/matrix.cpp

pratikvn · 2021-12-21T09:53:08Z

test/matrix/matrix.cpp

+    static void check_property(const std::unique_ptr<matrix_type>&) {}
+};
+
+struct DenseWithDefaultStride : SimpleMatrixTest<gko::matrix::Dense<double>> {


Would it be too difficult to test for all types ?

no, that's definitely possible! I just started with the easy ones

test/matrix/matrix.cpp

Slaedr

Excellent work! This is very cool.

test/matrix/matrix.cpp

yhmtsai

LGTM. Thanks for implementing it! some nit and question in review comments.

yhmtsai · 2021-12-23T07:18:16Z

test/matrix/matrix.cpp

+    }
+};
+
+struct Coo : SimpleMatrixTest<gko::matrix::Coo<double, int>> {};


also test for different type?

test/matrix/matrix.cpp

Co-authored-by: Aditya Kashi <aditya.kashi@kit.edu> Co-authored-by: Yuhsiang Tsai <yhmtsai@gmail.com>

This also involves a few bugfixes for edge cases with ELL matrices with less columns than nonzeros per row. This can be reverted once ELL gets actual symbolic zeros

ginkgo-bot · 2022-02-02T23:31:19Z

Note: This PR changes the Ginkgo ABI:

Functions changes summary: 0 Removed, 0 Changed (32 filtered out), 8 Added functions
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

For details check the full ABI diff under Artifacts here

sonarcloud · 2022-02-03T11:21:06Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
89 Code Smells

21.6% Coverage
1.9% Duplication

Advertise release 1.5.0 and last changes + Add changelog, + Update third party libraries + A small fix to a CMake file See PR: #1195 The Ginkgo team is proud to announce the new Ginkgo minor release 1.5.0. This release brings many important new features such as: - MPI-based multi-node support for all matrix formats and most solvers; - full DPC++/SYCL support, - functionality and interface for GPU-resident sparse direct solvers, - an interface for wrapping solvers with scaling and reordering applied, - a new algebraic Multigrid solver/preconditioner, - improved mixed-precision support, - support for device matrix assembly, and much more. If you face an issue, please first check our [known issues page](https://github.com/ginkgo-project/ginkgo/wiki/Known-Issues) and the [open issues list](https://github.com/ginkgo-project/ginkgo/issues) and if you do not find a solution, feel free to [open a new issue](https://github.com/ginkgo-project/ginkgo/issues/new/choose) or ask a question using the [github discussions](https://github.com/ginkgo-project/ginkgo/discussions). Supported systems and requirements: + For all platforms, CMake 3.13+ + C++14 compliant compiler + Linux and macOS + GCC: 5.5+ + clang: 3.9+ + Intel compiler: 2018+ + Apple LLVM: 8.0+ + NVHPC: 22.7+ + Cray Compiler: 14.0.1+ + CUDA module: CUDA 9.2+ or NVHPC 22.7+ + HIP module: ROCm 4.0+ + DPC++ module: Intel OneAPI 2021.3 with oneMKL and oneDPL. Set the CXX compiler to `dpcpp`. + Windows + MinGW and Cygwin: GCC 5.5+ + Microsoft Visual Studio: VS 2019 + CUDA module: CUDA 9.2+, Microsoft Visual Studio + OpenMP module: MinGW or Cygwin. Algorithm and important feature additions: + Add MPI-based multi-node for all matrix formats and solvers (except GMRES and IDR). ([#676](#676), [#908](#908), [#909](#909), [#932](#932), [#951](#951), [#961](#961), [#971](#971), [#976](#976), [#985](#985), [#1007](#1007), [#1030](#1030), [#1054](#1054), [#1100](#1100), [#1148](#1148)) + Porting the remaining algorithms (preconditioners like ISAI, Jacobi, Multigrid, ParILU(T) and ParIC(T)) to DPC++/SYCL, update to SYCL 2020, and improve support and performance ([#896](#896), [#924](#924), [#928](#928), [#929](#929), [#933](#933), [#943](#943), [#960](#960), [#1057](#1057), [#1110](#1110), [#1142](#1142)) + Add a Sparse Direct interface supporting GPU-resident numerical LU factorization, symbolic Cholesky factorization, improved triangular solvers, and more ([#957](#957), [#1058](#1058), [#1072](#1072), [#1082](#1082)) + Add a ScaleReordered interface that can wrap solvers and automatically apply reorderings and scalings ([#1059](#1059)) + Add a Multigrid solver and improve the aggregation based PGM coarsening scheme ([#542](#542), [#913](#913), [#980](#980), [#982](#982), [#986](#986)) + Add infrastructure for unified, lambda-based, backend agnostic, kernels and utilize it for some simple kernels ([#833](#833), [#910](#910), [#926](#926)) + Merge different CUDA, HIP, DPC++ and OpenMP tests under a common interface ([#904](#904), [#973](#973), [#1044](#1044), [#1117](#1117)) + Add a device_matrix_data type for device-side matrix assembly ([#886](#886), [#963](#963), [#965](#965)) + Add support for mixed real/complex BLAS operations ([#864](#864)) + Add a FFT LinOp for all but DPC++/SYCL ([#701](#701)) + Add FBCSR support for NVIDIA and AMD GPUs and CPUs with OpenMP ([#775](#775)) + Add CSR scaling ([#848](#848)) + Add array::const_view and equivalent to create constant matrices from non-const data ([#890](#890)) + Add a RowGatherer LinOp supporting mixed precision to gather dense matrix rows ([#901](#901)) + Add mixed precision SparsityCsr SpMV support ([#970](#970)) + Allow creating CSR submatrix including from (possibly discontinuous) index sets ([#885](#885), [#964](#964)) + Add a scaled identity addition (M <- aI + bM) feature interface and impls for Csr and Dense ([#942](#942)) Deprecations and important changes: + Deprecate AmgxPgm in favor of the new Pgm name. ([#1149](#1149)). + Deprecate specialized residual norm classes in favor of a common `ResidualNorm` class ([#1101](#1101)) + Deprecate CamelCase non-polymorphic types in favor of snake_case versions (like array, machine_topology, uninitialized_array, index_set) ([#1031](#1031), [#1052](#1052)) + Bug fix: restrict gko::share to rvalue references (*possible interface break*) ([#1020](#1020)) + Bug fix: when using cuSPARSE's triangular solvers, specifying the factory parameter `num_rhs` is now required when solving for more than one right-hand side, otherwise an exception is thrown ([#1184](#1184)). + Drop official support for old CUDA < 9.2 ([#887](#887)) Improved performance additions: + Reuse tmp storage in reductions in solvers and add a mutable workspace to all solvers ([#1013](#1013), [#1028](#1028)) + Add HIP unsafe atomic option for AMD ([#1091](#1091)) + Prefer vendor implementations for Dense dot, conj_dot and norm2 when available ([#967](#967)). + Tuned OpenMP SellP, COO, and ELL SpMV kernels for a small number of RHS ([#809](#809)) Fixes: + Fix various compilation warnings ([#1076](#1076), [#1183](#1183), [#1189](#1189)) + Fix issues with hwloc-related tests ([#1074](#1074)) + Fix include headers for GCC 12 ([#1071](#1071)) + Fix for simple-solver-logging example ([#1066](#1066)) + Fix for potential memory leak in Logger ([#1056](#1056)) + Fix logging of mixin classes ([#1037](#1037)) + Improve value semantics for LinOp types, like moved-from state in cross-executor copy/clones ([#753](#753)) + Fix some matrix SpMV and conversion corner cases ([#905](#905), [#978](#978)) + Fix uninitialized data ([#958](#958)) + Fix CUDA version requirement for cusparseSpSM ([#953](#953)) + Fix several issues within bash-script ([#1016](#1016)) + Fixes for `NVHPC` compiler support ([#1194](#1194)) Other additions: + Simplify and properly name GMRES kernels ([#861](#861)) + Improve pkg-config support for non-CMake libraries ([#923](#923), [#1109](#1109)) + Improve gdb pretty printer ([#987](#987), [#1114](#1114)) + Add a logger highlighting inefficient allocation and copy patterns ([#1035](#1035)) + Improved and optimized test random matrix generation ([#954](#954), [#1032](#1032)) + Better CSR strategy defaults ([#969](#969)) + Add `move_from` to `PolymorphicObject` ([#997](#997)) + Remove unnecessary device_guard usage ([#956](#956)) + Improvements to the generic accessor for mixed-precision ([#727](#727)) + Add a naive lower triangular solver implementation for CUDA ([#764](#764)) + Add support for int64 indices from CUDA 11 onward with SpMV and SpGEMM ([#897](#897)) + Add a L1 norm implementation ([#900](#900)) + Add reduce_add for arrays ([#831](#831)) + Add utility to simplify Dense View creation from an existing Dense vector ([#1136](#1136)). + Add a custom transpose implementation for Fbcsr and Csr transpose for unsupported vendor types ([#1123](#1123)) + Make IDR random initilization deterministic ([#1116](#1116)) + Move the algorithm choice for triangular solvers from Csr::strategy_type to a factory parameter ([#1088](#1088)) + Update CUDA archCoresPerSM ([#1175](#1116)) + Add kernels for Csr sparsity pattern lookup ([#994](#994)) + Differentiate between structural and numerical zeros in Ell/Sellp ([#1027](#1027)) + Add a binary IO format for matrix data ([#984](#984)) + Add a tuple zip_iterator implementation ([#966](#966)) + Simplify kernel stubs and declarations ([#888](#888)) + Simplify GKO_REGISTER_OPERATION with lambdas ([#859](#859)) + Simplify copy to device in tests and examples ([#863](#863)) + More verbose output to array assertions ([#858](#858)) + Allow parallel compilation for Jacobi kernels ([#871](#871)) + Change clang-format pointer alignment to left ([#872](#872)) + Various improvements and fixes to the benchmarking framework ([#750](#750), [#759](#759), [#870](#870), [#911](#911), [#1033](#1033), [#1137](#1137)) + Various documentation improvements ([#892](#892), [#921](#921), [#950](#950), [#977](#977), [#1021](#1021), [#1068](#1068), [#1069](#1069), [#1080](#1080), [#1081](#1081), [#1108](#1108), [#1153](#1153), [#1154](#1154)) + Various CI improvements ([#868](#868), [#874](#874), [#884](#884), [#889](#889), [#899](#899), [#903](#903), [#922](#922), [#925](#925), [#930](#930), [#936](#936), [#937](#937), [#958](#958), [#882](#882), [#1011](#1011), [#1015](#1015), [#989](#989), [#1039](#1039), [#1042](#1042), [#1067](#1067), [#1073](#1073), [#1075](#1075), [#1083](#1083), [#1084](#1084), [#1085](#1085), [#1139](#1139), [#1178](#1178), [#1187](#1187))

upsj added the 1:ST:ready-for-review This PR is ready for review label Oct 11, 2021

upsj added this to the Ginkgo 1.5.0 milestone Oct 11, 2021

upsj self-assigned this Oct 11, 2021

upsj added 1:ST:need-feedback The PR is somewhat ready but feedback on a blocking topic is required before a proper review. and removed 1:ST:ready-for-review This PR is ready for review labels Oct 11, 2021

ginkgo-bot added reg:build This is related to the build system. type:matrix-format This is related to the Matrix formats labels Oct 11, 2021

upsj force-pushed the spmv_test branch from 3081b2f to 8b27319 Compare October 15, 2021 15:15

This was referenced Oct 15, 2021

Format conversion, SpMV and write improvements #905

Merged

Add device_matrix_data and device-side matrix::read #886

Merged

Create submatrix for sparse matrix formats #885

Merged

upsj force-pushed the spmv_test branch from 3ec18c8 to 0070c85 Compare December 9, 2021 14:50

upsj requested a review from a team December 17, 2021 09:12

upsj added 1:ST:ready-for-review This PR is ready for review and removed 1:ST:need-feedback The PR is somewhat ready but feedback on a blocking topic is required before a proper review. labels Dec 17, 2021

pratikvn approved these changes Dec 21, 2021

View reviewed changes

Slaedr approved these changes Dec 21, 2021

View reviewed changes

test/matrix/matrix.cpp Outdated Show resolved Hide resolved

yhmtsai approved these changes Dec 23, 2021

View reviewed changes

upsj force-pushed the spmv_test branch from 0070c85 to 2c322be Compare February 1, 2022 08:50

upsj added the 1:ST:run-full-test label Feb 1, 2022

upsj added 4 commits February 1, 2022 14:25

add generic matrix test

a8c1609

move empty matrix tests into other test functions

f458e1b

improve matrix test

114866b

fix uninitialized memory in conversions to Dense

690a45a

upsj force-pushed the spmv_test branch from 9ee9e43 to 690a45a Compare February 1, 2022 13:26

review updates

d506ea8

Co-authored-by: Aditya Kashi <aditya.kashi@kit.edu> Co-authored-by: Yuhsiang Tsai <yhmtsai@gmail.com>

upsj added 1:ST:ready-to-merge This PR is ready to merge. and removed 1:ST:ready-for-review This PR is ready for review 1:ST:run-full-test labels Feb 1, 2022

upsj added 4 commits February 1, 2022 16:50

fix empty kernel launch in COO SpMV

6398981

fix MSVC compilation

782c68a

make generic dpcpp matrix tests float-only

55a8023

fix Hybrid conversions and read

4406c76

This also involves a few bugfixes for edge cases with ELL matrices with less columns than nonzeros per row. This can be reverted once ELL gets actual symbolic zeros

upsj force-pushed the spmv_test branch from caf04d2 to 4406c76 Compare February 2, 2022 19:10

upsj mentioned this pull request Feb 2, 2022

Current NOT_IMPLEMENTED kernels #286

Open

65 tasks

simplify and add missing DPCPP kernels

c6d4152

upsj merged commit 083fb87 into develop Feb 3, 2022

upsj deleted the spmv_test branch February 3, 2022 09:30

upsj mentioned this pull request Feb 28, 2022

Fix failing matrix tests #978

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add generic matrix format test #904

Add generic matrix format test #904

upsj commented Oct 11, 2021 •

edited

Loading

yhmtsai commented Oct 29, 2021

pratikvn left a comment

pratikvn Dec 21, 2021

upsj Dec 21, 2021

Slaedr left a comment

yhmtsai left a comment

yhmtsai Dec 23, 2021

ginkgo-bot commented Feb 2, 2022

sonarcloud bot commented Feb 3, 2022

Add generic matrix format test #904

Add generic matrix format test #904

Conversation

upsj commented Oct 11, 2021 • edited Loading

yhmtsai commented Oct 29, 2021

pratikvn left a comment

Choose a reason for hiding this comment

pratikvn Dec 21, 2021

Choose a reason for hiding this comment

upsj Dec 21, 2021

Choose a reason for hiding this comment

Slaedr left a comment

Choose a reason for hiding this comment

yhmtsai left a comment

Choose a reason for hiding this comment

yhmtsai Dec 23, 2021

Choose a reason for hiding this comment

ginkgo-bot commented Feb 2, 2022

sonarcloud bot commented Feb 3, 2022

upsj commented Oct 11, 2021 •

edited

Loading