-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data Validation #770
Draft
greole
wants to merge
30
commits into
ginkgo-project:develop
Choose a base branch
from
greole:data_validation
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Data Validation #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- reuse CALL_AND_RETURN_IF_CASTABLE macro - generalise GKO_CALL_FOR_EACH_(NON_COMPLEX)_VALUE_AND_INDEX_TYPE
* add prefixed macro definition * Data validation macro generalisation fix windows (#2) * check if linebreak causes windows build to break * check if linebreak causes windows build to break * check if empty macro arg causes windows build to break * test if removing VA_ARGS resolves msvc error * test PASS_ON hack * Add missing PASS_ON * Add tests for complex values is_finite tests * Refactor macro expansion macro * Test if PASS_ON is needed when calling GKO_APPLY_MACRO * Refactor CALL_AND_RETURN_IF_CASTABLE macro * Moves GKO_CALL_FOR_... macros to types.hpp
greole
added
is:enhancement
An improvement of an existing feature.
mod:core
This is related to the core module.
type:solver
This is related to the solvers
type:preconditioner
This is related to the preconditioners
type:matrix-format
This is related to the Matrix formats
1:ST:WIP
This PR is a work in progress. Not ready for review.
type:factorization
This is related to the Factorizations
labels
May 20, 2021
- includes unit tests for is_*_triangular - unit tests for matrix validation function are testing for Coo and Csr - some minor fixes
1. Unit tests are simplified and are only based on Coo, because the validation helpers rely on matrix_data and conversion to the specific matrix data type is tested elsewhere. 2. The predicate for all_of has been corrected by inverting it. 3. The non_zero_diagonal now also tests for missing elements.
greole
added
1:ST:ready-to-merge
This PR is ready to merge.
1:ST:need-feedback
The PR is somewhat ready but feedback on a blocking topic is required before a proper review.
1:ST:WIP
This PR is a work in progress. Not ready for review.
and removed
1:ST:WIP
This PR is a work in progress. Not ready for review.
1:ST:ready-to-merge
This PR is ready to merge.
1:ST:need-feedback
The PR is somewhat ready but feedback on a blocking topic is required before a proper review.
labels
Nov 2, 2021
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
1:ST:WIP
This PR is a work in progress. Not ready for review.
is:enhancement
An improvement of an existing feature.
mod:core
This is related to the core module.
type:factorization
This is related to the Factorizations
type:matrix-format
This is related to the Matrix formats
type:preconditioner
This is related to the preconditioners
type:solver
This is related to the solvers
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements data validation strategies as outlined in #746. The aim is to provide a set of validation functions, to evaluate the validity of matrices for debug builds.
The implementation is done in several stages:
Free functions checking:
Matrices:
Factorizations:
Preconditioners:
Solvers: