Use Index map in PGM #1639
Open
Use Index map in PGM #1639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginkgo-bot
added
reg:testing
MarcelKoch
force-pushed
the
index-map-pgm
branch
2 times, most recently
from
56d235d
to
b0e5f6d
Compare
MarcelKoch
force-pushed
the
index-map-pgm
branch
2 times, most recently
from
f594348
to
87d62d3
Compare
yhmtsai
reviewed
Jul 10, 2024
Comment on lines
+284
to
+285
| auto seng_global_agg = imap.map_to_global( | ||
| send_agg, experimental::distributed::index_space::local); |
There was a problem hiding this comment.
If I guess it correctly, you map the local index back to the global index to avoid the collision.
this is what I want to avoid because it needs twice of memory transferring between nodes.
There was a problem hiding this comment.
I would guess that the actual volume of the data transfer is negligible compared to the latency cost. Also, this is significantly simpler to what was there before.
MarcelKoch
force-pushed
the
index-map-pgm
branch
3 times, most recently
from
9e52a2c
to
ded4dd3
Compare
MarcelKoch
force-pushed
the
index-map-pgm
branch
2 times, most recently
from
9e52a2c
to
ded4dd3
Compare
this also changes one constructor
MarcelKoch
force-pushed
the
index-map-pgm
branch
from
ded4dd3
to
3ad5eee
Compare
MarcelKoch
requested review from
yhmtsai and
a team
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables using an index map to create the coarse level using PGM for distributed matrices. IMO this simplifies the PGM implementation, since there is no 'manual' implementation needed anymore.
This also has some consequences for the
distributed::Matrixclass. Namely, when creating a matrix with from local and non-local parts, an index map has to be supplied, instead of the list of vectors. Again, I think this should simplify the interface. Note that currently there is no accessor to the index map, since it's not necessary. But it might be useful for consistency.I guess this is also an interface breaking change.
Todo:
gather_as_global_index