-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sor kernels #1634
base: sor
Are you sure you want to change the base?
Add Sor kernels #1634
Conversation
0d29fae
to
1f1ef07
Compare
a94cab2
to
7c59123
Compare
a30fee7
to
79ed6d7
Compare
namespace factorization { | ||
namespace helpers { | ||
|
||
using namespace ::gko::factorization; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it does not help anything below, so I would rather remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make this more reasonable, I also removed the factorization
namespace in the core file. Otherwise I would have had to use ::gko::factorization::
everywhere instead of just helpers::
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, I thought they are in the same namespace, but one is under kernel namespace and the other is under gko directly.
then the original one is better as it does not give any ambiguous function.
although it can only declare the two class you need, it's a bit annoying with the template.
namespace helpers { | ||
|
||
|
||
using namespace ::gko::factorization; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here and for the others.
@@ -0,0 +1,67 @@ | |||
// SPDX-FileCopyrightText: 2017 - 2024 The Ginkgo authors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the file can go into unified one but you need to do dispatch on the header of factorization_helpers.hpp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you may need to use GKO_KERNEL
for the lambda function.
Maybe also for the actual kernel?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this complicates our unified setup again, and it's not using the unified kernels as intended.
We use the unified kernels, when the kernel implementation are identical, which is not the case here. I think it's close, but it would require some adjustments of the factorization kernels. If that's feasible, I would prefer to do it in another PR.
} // namespace factorization | ||
} // namespace GKO_DEVICE_NAMESPACE | ||
} // namespace kernels | ||
} // namespace gko |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} // namespace gko | |
} // namespace gko | |
nit
namespace factorization { | ||
namespace helpers { | ||
|
||
using namespace ::gko::factorization; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, I thought they are in the same namespace, but one is under kernel namespace and the other is under gko directly.
then the original one is better as it does not give any ambiguous function.
although it can only declare the two class you need, it's a bit annoying with the template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I need to take my previous comment about the using namespace back because I thought they are in the same namespace, which is wrong.
1e8f3ac
to
0bf9b7e
Compare
- formatting Co-authored-by: Yu-Hsiang M. Tsai <yhmtsai@gmail.com>
0bf9b7e
to
edb44d4
Compare
This PR adds the device kernels for #1633.