Minimal stopping criteria config #1613
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginkgo-bot
added
reg:testing
Merged
yhmtsai
reviewed
May 17, 2024
| } | ||
|
|
||
| if (config.get_tag() == pnode::tag_t::map) { | ||
| return parse_minimal_criteria(config, context, td); |
There was a problem hiding this comment.
Suggested change
| return parse_minimal_criteria(config, context, td); | |
| auto updated = config::update_type(td); | |
| return parse_minimal_criteria(config, context, updated); |
It is to support no valuetype available outside
There was a problem hiding this comment.
I'm not sure what you mean here. I can specify the value type of the residual nom criterion, as you can see in the tests.
There was a problem hiding this comment.
It's based on the type_descriptor from the outer loop.
I mean something like
"stop": {
"value_type": "float64",
"residual_norm": ...
}
in case no precision information from outside or want to specify certain precision for stop.
core/config/config_helper.cpp
Outdated
| parse_or_get_criteria(const pnode& config, const registry& context, | ||
| const type_descriptor& td) | ||
| { | ||
| if (config.get_tag() == pnode::tag_t::array) { |
There was a problem hiding this comment.
The array can not accept 1 object now. you can use type to distinguish the path and reuse the parse_or_get_factory
yhmtsai
force-pushed
the
factory_config
branch
2 times, most recently
from
7735cc5
to
2629167
Compare
MarcelKoch
force-pushed
the
minimal-stop-config
branch
from
0126f7d
to
829b991
Compare
MarcelKoch
added
the
1:ST:WIP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a minimal specification for configuring stopping criteria. The test now contains an example for this configuration. Since the main implementation to configure the criteria is already implemented, this adds only a bit of dispatching.
This is intended to continue the discussion in #1392, while not blocking the release.
Todo: