-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify the testing types #1594
base: develop
Are you sure you want to change the base?
Conversation
d648b9a
to
5d94d98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally lgtm. The biggest issue for me is the documentation. It's dupliated a lot and should only be in one place (I think I would prefer the aliases in the gko::test
namespace).
Add template type functions to combine and merge type lists. As a result, the GINKGO_DPCPP_SINGLE_MODE only needs to be present once. Additionally, change the typen name ValueAndIndexType to ComplexAndPODTypes (because gko::size_type is not an IndexType).
Additionally, introduce `IntegerTypes`, which is IndexTypes combined with gko::size_type (used for the prefix sum tests).
Additionally, add tests for empty inputs.
e05756d
to
869b2c4
Compare
869b2c4
to
795db27
Compare
Error: The following files need to be formatted:
You can find a formatting patch under Artifacts here or run |
Add template-type functions to combine and merge type lists. As a result, the GINKGO_DPCPP_SINGLE_MODE only needs to be present once.
Additionally, change the typen name ValueAndIndexType to ComplexAndPODTypes (because gko::size_type is not an IndexType).
TODO: