ELLPACK matrix format #1
Comments
gflegar
added
the
is:new-feature
|
Dear Professor Goran, |
|
@yanjen you did everything correctly! No need to change anything as far as opening the pull request is concerned. This is an issue (where you discuss what's supposed to be done), and #10 is a pull request (where you present the code once you've done it). To be honest, I have no idea why github shares the counter between issues and pull requests, and I too find it a bit confusing (gitlab has separate counters for example). You can however "link" the issue to the pull request and have it automatically closed when the PR is merged, as explained here: https://github.com/blog/1506-closing-issues-via-pull-requests |
* add prefixed macro definition * Data validation macro generalisation fix windows (#2) * check if linebreak causes windows build to break * check if linebreak causes windows build to break * check if empty macro arg causes windows build to break * test if removing VA_ARGS resolves msvc error * test PASS_ON hack * Add missing PASS_ON * Add tests for complex values is_finite tests * Refactor macro expansion macro * Test if PASS_ON is needed when calling GKO_APPLY_MACRO * Refactor CALL_AND_RETURN_IF_CASTABLE macro * Moves GKO_CALL_FOR_... macros to types.hpp
* add prefixed macro definition * Data validation macro generalisation fix windows (#2) * check if linebreak causes windows build to break * check if linebreak causes windows build to break * check if empty macro arg causes windows build to break * test if removing VA_ARGS resolves msvc error * test PASS_ON hack * Add missing PASS_ON * Add tests for complex values is_finite tests * Refactor macro expansion macro * Test if PASS_ON is needed when calling GKO_APPLY_MACRO * Refactor CALL_AND_RETURN_IF_CASTABLE macro * Moves GKO_CALL_FOR_... macros to types.hpp
* add prefixed macro definition * Data validation macro generalisation fix windows (#2) * check if linebreak causes windows build to break * check if linebreak causes windows build to break * check if empty macro arg causes windows build to break * test if removing VA_ARGS resolves msvc error * test PASS_ON hack * Add missing PASS_ON * Add tests for complex values is_finite tests * Refactor macro expansion macro * Test if PASS_ON is needed when calling GKO_APPLY_MACRO * Refactor CALL_AND_RETURN_IF_CASTABLE macro * Moves GKO_CALL_FOR_... macros to types.hpp
gko::matrix::Ellclass template incore/matrix/ell.hppcore/matrix/ell.cppNOT_IMPLEMENTEDcore/test/matrix/ell.cppcontributors.txt😄The text was updated successfully, but these errors were encountered: