Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ugorji/go@v1.1.4 instead of ugorji/go/codec. #87

Merged
merged 4 commits into from
May 12, 2019
Merged

Use ugorji/go@v1.1.4 instead of ugorji/go/codec. #87

merged 4 commits into from
May 12, 2019

Conversation

maerics
Copy link
Contributor

@maerics maerics commented May 12, 2019

Fixes #86 by updating the ugorji/go dependency.

@thinkerou
Copy link
Member

please update the whole go mod and file,thanks!

@thinkerou
Copy link
Member

when you run ‘go mod tidy’, go.mod and go.sum will automatically update.

@maerics
Copy link
Contributor Author

maerics commented May 12, 2019

Right. Is that not what we wanted here? Sorry for the confusing, I'm still learning the finer points of go modules.

@thinkerou
Copy link
Member

thinkerou commented May 12, 2019

@maerics gin upgrade 1.4.0 version now, so you also should update gin.
you can run the follow command to update all depend package.

  1. rm go.mod
  2. rm go.sum
  3. go mod tidy
    This will update go.mod and go.sum, you commit them to repo.
    Thanks!

I have committed pull request to your branch.

@thinkerou thinkerou self-requested a review May 12, 2019 06:27
@thinkerou thinkerou merged commit 3cb4c4f into gin-contrib:master May 12, 2019
@maerics
Copy link
Contributor Author

maerics commented May 12, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot load github.com/ugorji/go/codec: ambiguous import: found .... in multiple modules
2 participants