Android compatibility

[Rudloff]

Hello,

Here is a patch that allows psutil to build on Android (with Termux).
However it does not passes all the tests.

ifaddrs.h does not exist on Android, so I included it from here: https://github.com/morristech/android-ifaddrs

[Rudloff]

I wish there was a cleaner way but sys.platform returns linux on Android.

[giampaolo]

This is very interesting. Some comments:

• did you try to run tests? Do they all pass?
• how does this differ from net_if_addrs() on Linux?
• the C code needs some styling adjustments such as lines max 80 chars and:

if condition {
}

instead of

if condition
{
}

[Rudloff]

• Some tests failed. Here is the complete output: https://gist.github.com/Rudloff/2e2c3f6e4b224db2effaf2b3720dac59
• It seems to work almost like on Linux. Here is an exemple output:

{'wlan0': [snic(family=<AddressFamily.AF_INET: 2>, address='10.0.242.196', netmask='255.255.255.0', broadcast='10.0.242.255', ptp=None), snic(family=<AddressFamily.AF_INET6: 10>, address='2a00:5881:8118:500:e151:2cc9:8a84:a418', netmask='ffff:ffff:ffff:ffff::', broadcast=None, ptp=None), snic(family=<AddressFamily.AF_INET6: 10>, address='2a00:5881:8118:500:86cf:bfff:fe89:4f06', netmask='ffff:ffff:ffff:ffff::', broadcast=None, ptp=None), snic(family=<AddressFamily.AF_INET6: 10>, address='fe80::86cf:bfff:fe89:4f06%wlan0', netmask='ffff:ffff:ffff:ffff::', broadcast=None, ptp=None), snic(family=<AddressFamily.AF_PACKET: 17>, address='84:cf:bf:89:4f:06', netmask=None, broadcast='ff:ff:ff:ff:ff:ff', ptp=None)], 'dummy0': [snic(family=<AddressFamily.AF_PACKET: 17>, address='2e:42:bf:cb:c8:9d', netmask=None, broadcast='ff:ff:ff:ff:ff:ff', ptp=None)], 'sit0': [snic(family=<AddressFamily.AF_PACKET: 17>, address='00:00:00:00:00:00', netmask=None, broadcast=None, ptp=None)], 'rmnet_usb0': [snic(family=<AddressFamily.AF_PACKET: 17>, address='be:ae:92:8b:0b:a4', netmask=None, broadcast='ff:ff:ff:ff:ff:ff', ptp=None)], 'rev_rmnet1': [snic(family=<AddressFamily.AF_PACKET: 17>, address='16:18:0e:93:01:62', netmask=None, broadcast='ff:ff:ff:ff:ff:ff', ptp=None)], 'rev_rmnet0': [snic(family=<AddressFamily.AF_PACKET: 17>, address='86:37:6b:10:9b:02', netmask=None, broadcast='ff:ff:ff:ff:ff:ff', ptp=None)], 'rev_rmnet3': [snic(family=<AddressFamily.AF_PACKET: 17>, address='62:7b:e4:87:c0:6e', netmask=None, broadcast='ff:ff:ff:ff:ff:ff', ptp=None)], 'rev_rmnet2': [snic(family=<AddressFamily.AF_PACKET: 17>, address='ce:6a:7d:43:20:ee', netmask=None, broadcast='ff:ff:ff:ff:ff:ff', ptp=None)], 'rev_rmnet5': [snic(family=<AddressFamily.AF_PACKET: 17>, address='ca:c6:29:23:8b:c8', netmask=None, broadcast='ff:ff:ff:ff:ff:ff', ptp=None)], 'rev_rmnet4': [snic(family=<AddressFamily.AF_PACKET: 17>, address='c2:71:78:ca:b1:00', netmask=None, broadcast='ff:ff:ff:ff:ff:ff', ptp=None)], 'rev_rmnet7': [snic(family=<AddressFamily.AF_PACKET: 17>, address='8a:47:b4:c3:8a:d6', netmask=None, broadcast='ff:ff:ff:ff:ff:ff', ptp=None)], 'rev_rmnet6': [snic(family=<AddressFamily.AF_PACKET: 17>, address='ee:1a:4c:b4:ac:4d', netmask=None, broadcast='ff:ff:ff:ff:ff:ff', ptp=None)], 'rev_rmnet8': [snic(family=<AddressFamily.AF_PACKET: 17>, address='36:af:31:bb:95:5c', netmask=None, broadcast='ff:ff:ff:ff:ff:ff', ptp=None)], 'lo': [snic(family=<AddressFamily.AF_INET: 2>, address='127.0.0.1', netmask='255.0.0.0', broadcast=None, ptp=None), snic(family=<AddressFamily.AF_INET6: 10>, address='::1%2181038467', netmask='ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff%25368064', broadcast=None, ptp=None), snic(family=<AddressFamily.AF_PACKET: 17>, address='00:00:00:00:00:00', netmask=None, broadcast=None, ptp=None)], 'p2p0': [snic(family=<AddressFamily.AF_PACKET: 17>, address='86:cf:bf:89:4f:06', netmask=None, broadcast='ff:ff:ff:ff:ff:ff', ptp=None)]}

• I have updated the code structures and cut some long lines, but like I said this is not my code and I'm not really familiar with C coding standards. Is there some kind of linter I could use to check the code?

[giampaolo]

So, getting back to this. I bumped into:
https://github.com/driftyco/ionic-box
...which AFAIU it lets you run Android on VirtualBox / Vagrant.
I installed and run this on Linux and psutil works just fine out of the box as this (ionic box) basically looks like a Linux Ubuntu distro, so I'm not entirely sure what I'm doing here.
Is this Android in the first place? If this is then it looks like your PR is not necessary.
What am I missing here?

[Rudloff]

Ionic Box is not and Android image. It is a Linux image that helps you build Android apps easily.
However thanks to termux/termux-packages#338 being fixed, some parts of my patch are not needed anymore. I will try to update it.

[giampaolo]

OK, as I thought I clearly lack some important pieces of this whole android picture. Can you perhaps tell me what I should do in order to set up an Android image so that I can experiment with this?
I'm on Linux btw.

[Rudloff]

It seems that my patch is not needed at all anymore, which is great news, so I'm closing this issue.

AFAIK the easiest way to run Android on Linux is to use the official emulator.