Bug 2439 fix for thermal zones #2440
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a bug in how high and critical temperatures are calculated when using thermal zones. Clear high and critical values each iteration so they are not divided by 1000 on subsequent iterations. Take the max value if multiple temperature trips target either high or critical. Signed-off-by: Siena Richard <sienarichard@samotics.com>
Signed-off-by: Siena Richard <sienarichard@samotics.com>
siena-sam
force-pushed
the
bug-2439-fix-for-thermal-zones
branch
from
47cf478
to
7f705e4
Compare
|
For confirmation, here are some screenshots of this fix verified on the ARM system we first noticed this on. Here is the bug seen in 5.9.8 which is the version we are currently using: Here is the bug fixed when running commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description
Store and clear values for the high and critical temperatures read from
thermal_zone#/trip_point_#_tempfiles. Otherwise, values will be incorrectly divided by 1000 (to account for milidegrees) for each trip point after the first that is of typecriticalorhigh.