Skip to content
This repository has been archived by the owner on Jun 14, 2020. It is now read-only.

Improve Profile Pages #158

Merged
merged 87 commits into from
Sep 26, 2018
Merged

Improve Profile Pages #158

merged 87 commits into from
Sep 26, 2018

Conversation

brillout
Copy link
Collaborator

@brillout brillout commented Sep 24, 2018

The checklist is still live at https://github.com/ghuser-io/ghuser.io/tree/daa1867de83c86a616d8d7791374d17ed252bf75/ui-feedback

Feel free to review as much or as less as you want.

On top of my head, some things we do differently code-wise:

  • I try to make non-local var names unique. Including css class names. Because JS/CSS is not typed and searching for a CSS class name ".icon" is not convenient.
  • I choose inline styles over global CSS class names
  • I'm ok with big files. I'd choose one big file and a clean interface over many smaller files. E.g. Contrib.js is relatively big now which I like because it encapsulates lot's of code.

@brillout brillout assigned brillout and lourot and unassigned brillout Sep 24, 2018
Copy link
Member

@lourot lourot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks ❤️ (not done reviewing yet)

@lourot
Copy link
Member

lourot commented Sep 26, 2018

Many repo icons are actually missing on the tiny contribs. For these tiny contribs, you forgot to fall back to the org icons if there is no icon defined in the repo settings. For example on your own profile, your tiny contrib to facebook/react should have the icon of the facebook org.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants