Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing changelog #327

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Fix parsing changelog #327

merged 1 commit into from
Jun 26, 2023

Conversation

Gustry
Copy link
Collaborator

@Gustry Gustry commented Jun 26, 2023

When releasing latest release, we can notice there isn't any changelog included :
https://github.com/ghtmtt/DataPlotly/releases

It's missing a dash, it should follow Keep a Changelog : https://keepachangelog.com/en/1.0.0/

@Gustry Gustry requested a review from ghtmtt June 26, 2023 08:17
@Gustry
Copy link
Collaborator Author

Gustry commented Jun 26, 2023

Side note, I'm not sure why there is two releases 4.0.2 (one prerelease and one not) https://github.com/ghtmtt/DataPlotly/releases

@ghtmtt ghtmtt merged commit 7b5d552 into ghtmtt:master Jun 26, 2023
@Gustry Gustry deleted the fix-changelog branch June 26, 2023 08:21
@ghtmtt
Copy link
Owner

ghtmtt commented Jun 26, 2023

Side note, I'm not sure why there is two releases 4.0.2 (one prerelease and one not) https://github.com/ghtmtt/DataPlotly/releases

that's because I stopped the workflow and recreated the tag.

Thanks for the fix! If I make a new tag right now it will re-trigger the workflow, so I'm adding the changelog information manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants