Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move layout properties to layout options group in widget #260

Merged
merged 5 commits into from
Mar 26, 2021

Conversation

SGroe
Copy link
Collaborator

@SGroe SGroe commented Mar 22, 2021

I would like to move all layout properties (e.g. plot title) to the new layout option group (introduced by #259). Only the ui file is changed here.

These layout properties only apply to the first plot, if multiple plots in a layout are defined. One idea I have in my mind is to (optionally) synchronize these layout properties across all plots of a layout item (to be done in a future pr).

@ghtmtt: What do you think about that? I you like that, I would add some minor improvements.

dataploty_layout_properties

@ghtmtt
Copy link
Owner

ghtmtt commented Mar 22, 2021

@SGroe I'm +1 on that. The layout configuration box can be extended with a lot of new widgets (axis color, fonts, sizes, etc) but this will be also something to think in a future (many actually ;) ) PR. But we should discuss this somewhere else.

This is ploty chart studio: https://chart-studio.plotly.com/create/#/ where basically all plotly customization are available (p.s. I never used chart studio ;) ).

@SGroe
Copy link
Collaborator Author

SGroe commented Mar 24, 2021

@ghtmtt, what do you think about moving the remaining non-layout properties to the first settings page (within "Properties" group). These include:

  • Legend title
  • Hover tooltip
  • Hover label as text
  • Label text position
  • Bar orientation
  • Normalization
  • Show statistics
  • Outliers
  • Violin side
  • Include box plots
  • Show mean line
  • Invert histogram direction
  • Cumulative histogram
  • Manual bin size

@ghtmtt
Copy link
Owner

ghtmtt commented Mar 25, 2021

are you suggesting to move basically all the widgets of the Advanced Configuration within the Layout Options block?

@SGroe
Copy link
Collaborator Author

SGroe commented Mar 25, 2021

I suggest to move the mentioned properties (legend title, hover tooltip, ...) to the "Properties" group on the first page. Currently, this group contains properties like "Marker Color" or "Opacity".

@SGroe
Copy link
Collaborator Author

SGroe commented Mar 25, 2021

Here are two screenshots. Note that the properties "Label text position" and "Bar orientation" moved from the second to the first page.

widget1

widget2

@ghtmtt
Copy link
Owner

ghtmtt commented Mar 25, 2021

I'd move the Legend Title to the Layout Options for the rest +1

@SGroe
Copy link
Collaborator Author

SGroe commented Mar 25, 2021

I can move it from 'Plot properties' to 'Properties'. I don't want to move it to the 'Layout options' because this group should only contain (layout) properties. Layout properties are set once and apply for all sub plots. The 'Legend Title' will be different for each sub plot.

@ghtmtt
Copy link
Owner

ghtmtt commented Mar 26, 2021

got it, + 1 for me! Thanks

@SGroe
Copy link
Collaborator Author

SGroe commented Mar 26, 2021

Here is an updated screenshot. I have moved 'Legend Title' to the 'Properties' group.

widget3

@SGroe SGroe merged commit 889d219 into ghtmtt:master Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants