Add missing scaling of draw interaction circles #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If draw interaction circles are synced to a geojson feature array, their radius should be scaled to reflect the difference in scale factor between the map view projection and ESPG:4236 used for geojson.
|
Hello @sjmallon , |
|
Currently released as |
ghettovoice
added a commit
that referenced
this pull request
Oct 3, 2019
- resolved #173, #174, #201, #135, #216, #132 #224 #225 #226, #230 - merged of pull requests #160, #175, #180, #185, #188, #191, #206, #208, #212, #213, #215, #221, #227, #231 Thanks to @baspeeters, @sjmallon, @janlazo, @categulario, @skymaze, @jemasfox, @owen-thurston, @agmt5989, @RemiDesgrange - improved property watchers - optional debug messages - fixed broken UMD version - simplified initial interaction/controls setup #95 - added `id` property for all ol components for easy identification - mixins, ol-ext and rx-ext now are build to single file package, imports from those packages are not changed - UMD version (dev/demo version) now includes all used stuff from `ol` package - updated documentation and README
ghettovoice
added a commit
that referenced
this pull request
Oct 3, 2019
- resolved #173, #174, #201, #135, #216, #132 #224 #225 #226, #230 - merged of pull requests #160, #175, #180, #185, #188, #191, #206, #208, #212, #213, #215, #221, #227, #231 Thanks to @baspeeters, @sjmallon, @janlazo, @categulario, @skymaze, @jemasfox, @owen-thurston, @agmt5989, @RemiDesgrange - improved property watchers - optional debug messages - fixed broken UMD version - simplified initial interaction/controls setup #95 - added `id` property for all ol components for easy identification - mixins, ol-ext and rx-ext now are build to single file package, imports from those packages are not changed - UMD version (dev/demo version) now includes all used stuff from `ol` package - updated documentation and README
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If draw interaction circles are synced to a geojson feature array, their
radius should be scaled to reflect the difference in scale factor
between the map view projection and ESPG:4236 used for geojson.
Currently, using an OSM base map and an EPSG:3857 view, synced GeoJSON "circles" (actually polygons) are larger than the drawn feature by an amount depending on latitude because no adjustment is made for the variable local scale factor. Below is an example from the south of the UK.