Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asciidoctorjs 3 #90

Closed
wants to merge 8 commits into from
Closed

Asciidoctorjs 3 #90

wants to merge 8 commits into from

Conversation

xavier-calland
Copy link
Contributor

Issue #89

@xavier-calland
Updates deps versions automatically
d283068 
with `npm update`
@xavier-calland
Changes CND to prevent redirections
804a025 
When fetching https://twemoji.maxcdn.com/2/svg/XXX.svg the response status
is "301 Moved Permanently" with "Location https://cdn.jsdelivr.net/npm/twemoji@latest/2/svg/XXX.svg"

To avoid redirections and  we change the CDN.

Moreover, asciidoctorjs in version 3 does not correctly manage these redirections to download images in SAFE mode.
Changing the CDN works around the problem.
@xavier-calland
Updates @asciidoctor/core
f1eb278
@xavier-calland
Updates libnpmpublish
b2ba14c
@xavier-calland
Updates mocha
6e05859
@xavier-calland
Updates pacote
6f0169d
@xavier-calland
Updates standard
d9fb8b1
@xavier-calland
Uses caret in dependency version
71abe81
@ggrossetie
Copy link
Owner

Thanks!
Could you please extract the CDN update (from https://twemoji.maxcdn.com to https://cdn.jsdelivr.net/npm/twemoji@latest) into a dedicated pull request?

Also, we need to say on "libnpmpublish": "~6.0". They frequently introduce breaking changes and as a result our publish task is probably not working with anything > 6.x.

Any reason to use ^ instead of ~ ? I would prefer to keep using ~x.y (unless you have a strong case for ^).

@xavier-calland
Copy link
Contributor Author

If the lib uses and respects SemVer(it may be a too big assomption), we can use ^x.y without risk. It will only use version x.z (with z >= y), so no breaking changes will be introduced.
This allows automatic updates with npm update.

If you prefer using ~, no problem :)

I prepare a PR for the CDN update.

@ggrossetie
Copy link
Owner

I've updated dependencies in 85959ac.
I just released version 0.5.0. Could you please give it a try?

@xavier-calland
Copy link
Contributor Author

Version 0.5.0 work fine for me.
Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xavier-calland @ggrossetie