Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llama : fix attention layer count sanity check #6550

Merged
merged 2 commits into from
Apr 8, 2024
Merged

llama : fix attention layer count sanity check #6550

merged 2 commits into from
Apr 8, 2024

Conversation

ggerganov
Copy link
Owner

@ggerganov ggerganov commented Apr 8, 2024 •
edited
Loading

@ggerganov ggerganov requested a review from compilade April 8, 2024 18:18
@compilade
llama : fix parentheses in attention layer count sanity check
7bab4c0 
There was otherwise a warning when compiling.
compilade
compilade approved these changes Apr 8, 2024
View reviewed changes
Copy link
Collaborator

@compilade compilade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! From my tests it seems to work.

The assertion will need to be changed again with Jamba (because some (but not all) of its layers are attention layers), but this will be fixed later, when it will be relevant.

@ggerganov ggerganov merged commit cc4a954 into master Apr 8, 2024
57 of 60 checks passed
@ggerganov ggerganov deleted the gg/quantize-mamba-assert branch April 8, 2024 19:25
tybalex pushed a commit to rubra-ai/tools.cpp that referenced this pull request Apr 17, 2024
@ggerganov @compilade @tybalex
llama : fix attention layer count sanity check (ggerganov#6550)
364e8c8 
* llama : fix attention layer count sanity check

* llama : fix parentheses in attention layer count sanity check

There was otherwise a warning when compiling.

---------

Co-authored-by: Francis Couture-Harpin <git@compilade.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compilade compilade compilade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggerganov @compilade