chore!: remove #[no_mangle] … extern "C" … from fns in bundle_ffi
#6272
+13
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErichDonGubler
force-pushed
the
no-exposed-render_bundle-c-symbols
branch
from
9526894
to
144fa41
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
ErichDonGubler
force-pushed
the
no-exposed-render_bundle-c-symbols
branch
from
144fa41
to
d0c5e58
Compare
ErichDonGubler
changed the title
extern "C" and unsafe from bundle_ffi module fns#[no_mangle] … extern "C" … from fns in bundle_ffi
|
I have a patch ready to go on the Firefox side, and I've confirmed it compiles: D223052 So we should be good to merge this! 😀 |
ErichDonGubler
force-pushed
the
no-exposed-render_bundle-c-symbols
branch
from
d0c5e58
to
df05571
Compare
ErichDonGubler
force-pushed
the
no-exposed-render_bundle-c-symbols
branch
from
df05571
to
d3a432c
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Resolves #3105.
Description
Remove the last remaining cases that should trigger #3105 in the
wgpu_core::command::bundle::bundle_ffimodule.Testing
If things still compile, we just gotta check that this doesn't break downstream. @cwfitzgerald, halp plz?
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.