Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spv-in parse more atomic ops #5824

Merged
merged 17 commits into from
Sep 18, 2024
Merged

spv-in parse more atomic ops #5824

merged 17 commits into from
Sep 18, 2024

Commits on Sep 16, 2024

  1. add parsing for spirv::Op::AtomicLoad and spirv::Op::AtomicStore

    @schell
    schell committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    2132a2b View commit details
    Browse the repository at this point in the history

  2. spv-in parse AtomicExchange and AtomicCompareExchange

    @schell
    schell committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    9558733 View commit details
    Browse the repository at this point in the history

  3. add atomic i decrement

    @schell
    schell committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    82a3cab View commit details
    Browse the repository at this point in the history

  4. bookend atomic store statement with emmitter.finish/emitter.start to … 

    …suppress a double load expression

bookend atomic result expressions with emitter.finish/start to prevent double defs
    @schell
    schell committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    0260fe4 View commit details
    Browse the repository at this point in the history

  5. add atomic iadd, isub, smin, umin, smax, umax, and, or, xor

    @schell
    schell committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    78fef24 View commit details
    Browse the repository at this point in the history

  6. parse atomic flag test and set, parse atomic flag clear

    @schell
    schell committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    c7d7c48 View commit details
    Browse the repository at this point in the history

  7. remove atomic compare exchange work

    @schell
    schell committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    144ca25 View commit details
    Browse the repository at this point in the history

  8. changelog

    @schell
    schell committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    9aa11c9 View commit details
    Browse the repository at this point in the history

  9. moved spirv tests into front/spv/mod.rs

    @schell
    schell committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    ebeb3cc View commit details
    Browse the repository at this point in the history

  10. feature gate atomic spv tests because they require wgsl-[in,out]

    @schell
    schell committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    3db2825 View commit details
    Browse the repository at this point in the history

  11. BlockContext::get_contained_global_variable returns Result

    @schell
    schell committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    6c83ac9 View commit details
    Browse the repository at this point in the history

  12. Generate spans covering the entire instruction. 

    Granted, there is pre-existing code in the SPIR-V front end that gets
this wrong, but:

It doesn't make sense to read `self.data_offset`, and then immediately
pass that to `self.span_from_with_op`. The point of that function is
to make the span cover the entire instruction, operands included.
    @jimblandy @schell
    jimblandy authored and schell committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    41f0b63 View commit details
    Browse the repository at this point in the history

  13. Move From implementation into spv front end

    @jimblandy
    jimblandy committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    01fc0d9 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. doc comments, minor cleanups

    @jimblandy
    jimblandy committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    1507ddd View commit details
    Browse the repository at this point in the history

  2. remove parsing of OpAtomicFlagClear and OpAtomicFlagTestAndSet

    @schell
    schell committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    d447db3 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'schell/feature/spirv-front-atomics-3-mo… 

    …re-ops' into feature/spirv-front-atomics-3-more-ops
    @schell
    schell committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    939f366 View commit details
    Browse the repository at this point in the history

  4. sync atomic spvasm files

    @schell
    schell committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    fb373ab View commit details
    Browse the repository at this point in the history