Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spv-in parse AtomicExchange #5822

Closed
wants to merge 26 commits into from
Closed

spv-in parse AtomicExchange #5822

wants to merge 26 commits into from

Conversation

schell
Copy link
Contributor

@schell schell commented Jun 16, 2024

Connections
Part of

Depends on

Requires rebase after #5821 merges.

Description

This adds parsing spirv::Op::AtomicExchange to naga::front::spv::Frontend::next_block.

Checklist

  • Run cargo fmt.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

schell and others added 26 commits June 13, 2024 15:08
@schell
added spv::Frontend::upgrade_atomics, replaces pointer type with atom…
0360c95 
…ic type
@schell
Recursively replace atomic pointer's type and expression
ca9fa56
@schell
remove all matches that aren't the bare minimum for the test case
c2a7034
@schell
remove copy
e810648
@schell
changelog, snapshot ron files
f80a417
@schell
remove unused iter_handles
46aff51
@jimblandy
Document AtomicOp and front::spv::Frontend::lookup_atomic.
d790a8f
@schell
include atomic_i_increment.spvasm
6340f6d
@schell
Merge remote-tracking branch 'schell/feature/spirv-front-atomics-2' i…
81c1ba5 
…nto feature/spirv-front-atomics-2
@schell
don't upgrade local variables, padding fixes
896f01d
@schell
modify global variable in place instead of appending
ef98fe9
@schell
remove PartialEq from LocalVariable, remove AtomicOpInst
52a375d
@schell
no need to call .into_iter() on iter
86aa3a4
@schell
maintain separate list of atomic ops for all functions and entry points
49339d1
@schell
use ty, inner and r#type for bindings
5d0d05c
@schell
index into arenas directly
059da60
@schell
fix atomic reference in docs
1ca4cf1
@schell
only track and upgrade global variables used in atomic ops
ed7f73a
@schell
WIP
4582dcd
@schell
find global variables in atomic pointers
780ad70
@schell
validate module in atomic upgrade test, ron files
346d11c
@schell
added atomic_load_and_store.spv* files
b12589e
@schell
move atomic_i_increment test to atomic_upgrade.rs
8a5eebc
@schell
add failing test for atomic load and store
6637d82
@schell
add parsing for spirv::Op::AtomicLoad and spirv::Op::AtomicStore
4c53b3a
@schell
spv-in parse AtomicExchange
9632334
@schell schell mentioned this pull request Jun 16, 2024
Open
@schell
Copy link
Contributor Author

schell commented Jun 16, 2024

Closing in favor of #5824

@schell schell closed this Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schell @jimblandy