Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure safety of indirect dispatch #5714
base: trunk
Are you sure you want to change the base?
Ensure safety of indirect dispatch #5714
Changes from all commits
0a1c8bf
97cdbc7
7a7bdf2
9817972
1354f18
0410f67
676a4d0
c3d50b8
db002de
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
RESET_BIND_GROUPS
test fails because we handle validation errors fatally inQueue::submit
. Because the current type signature unconditionally returns aSubmissionIndex
, I need to changewgpu_core
's internals to return it even when there's an error, so we can handle it non-fatally and use the validation error sink (as is according to spec., I think?).Tagging @cwfitzgerald, @Wumpf, and @jimblandy for validation on this approach. CC @teoxoy for 👀.