Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.15] WebGl workaround for drawing single instance #3596

Merged

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Mar 16, 2023

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections
#3578

Description
Whenever there is any instance attribute, we need to need use an instanced draw call on ANGLE. Otherwise, the following error will be (potentially spuriously) generated and may render incorrectly:

[.WebGL-0000554C38753500] GL_INVALID_OPERATION: Error: 0x00000502, in ..\..\third_party\angle\src\libANGLE\renderer\d3d\VertexDataManager.cpp, reserveSpaceForAttrib:520. Internal error: 0x00000502: Vertex buffer is not big enough for the draw call.

Testing
Tested on https://github.com/rerun-io/rerun

@Wumpf Wumpf changed the title V0.15 fix webgl workaround draw single instance [v0.15] WebGl workaround for drawing single instance Mar 16, 2023
@Wumpf Wumpf force-pushed the v0.15_fix-webgl-workaround-draw-single-instance branch from 9dd9e62 to de7a16b Compare March 16, 2023 18:03
@Wumpf Wumpf force-pushed the v0.15_fix-webgl-workaround-draw-single-instance branch from de7a16b to 43b6cc7 Compare March 18, 2023 15:53
@cwfitzgerald cwfitzgerald added the PR: needs back-porting PR with a fix that needs to land on crates label Mar 20, 2023
@grovesNL grovesNL merged commit ca9341b into gfx-rs:v0.15 Mar 20, 2023
@Wumpf Wumpf deleted the v0.15_fix-webgl-workaround-draw-single-instance branch March 20, 2023 18:28
@cwfitzgerald cwfitzgerald removed the PR: needs back-porting PR with a fix that needs to land on crates label Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants