webgl backend supports now non-srgb framebuffer #3070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 6, 2022
cwfitzgerald
requested changes
Oct 7, 2022
|
fairly sure it should "just work" with egl as we - as far as I've seen - resolve srgb there only via blit, never via shader. As writen in description, I failed to test it :/ |
Wumpf
force-pushed
the
webgl-non-srgb-support
branch
from
3f0a93e
to
89f1315
Compare
cwfitzgerald
approved these changes
Oct 8, 2022
Wumpf
force-pushed
the
webgl-non-srgb-support
branch
from
d1bfc89
to
ba2f00a
Compare
|
fixed changelog conflict in rebase (also added missing |
cwfitzgerald
approved these changes
Oct 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
fixes #3059
Description
enable non-srgb surfaces for gles
Still can't get around the texture copy due to the opengl coordinate flipping issue. But at least it's a "simple blit" which egl.rs already does (special care needed to be taken in the webgl case)
Testing
tested against egui in the browser which prefers non-srgb targets
patching wgpu in egui with this version (and building with the right feature flags) is sufficient :)
Tried testing egl.rs as well, but I'm failing to build angle for my apple silicon machine. I think it should work as well but if not this introduces a new bug (tit for tat!)