[spirv-out] Fix adding illegal decorators on fragment outputs. #2286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Furthermore, fix allowing to add `Centroid` and `Sample` decorator to vertex inputs. Fixes gfx-rs#2270
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #2286 +/- ##
==========================================
- Coverage 81.96% 81.96% -0.01%
==========================================
Files 80 80
Lines 43305 43302 -3
==========================================
- Hits 35496 35493 -3
Misses 7809 7809
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…hader Breaks HLSL & MSL validation
The struct in the file is only used as an output for the vertex stage and input for the fragment stage; this PR should have no effect on the SPIR-V output. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Furthermore, fix allowing to add
CentroidandSampledecorator to vertex inputs.Fixes #2270
Testing:
Verified this against the scenario in #2270 on a Windows machine and ran existing tests. I expected
interpolate.wgslto produce a different spirv because of my change onCentroidandSample, but it seems those are already suppressed elsewhere as well (?).Added test to verify how fragment outputs are passed out depending on type.