[glsl-in] Fix issues with shadow parameters #1965
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magcius
force-pushed
the
shadow-parameter
branch
3 times, most recently
from
59b4bcc
to
f5c06eb
Compare
Gordon-F
reviewed
Jun 2, 2022
| @@ -0,0 +1,17 @@ | |||
|
|
|||
There was a problem hiding this comment.
Could you rerun tests with the wgsl-out feature? It looks like your PR missing wgsl output snapshots.
The argument was getting converted to a Depth image, but the parameter type was not... see provided test.
|
Done. |
|
The test case you provided is still good so we can merge it |
|
Feel free to cherry-pick my test to your PR then. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The argument was getting converted to a Depth image,
but the parameter type was not... see provided test.