glsl-out: Implement bounds checks for ImageLoad
#1889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCapucho
force-pushed
the
glsl-out-bounds-checks
branch
3 times, most recently
from
f67e544
to
d5f6c6f
Compare
JCapucho
changed the title
ImageLoadImageLoad
|
@JCapucho Should we enable GLSL output for the |
|
I guess we'd have to add an actual entry point to the WGSL file, and have it call everything. |
JCapucho
force-pushed
the
glsl-out-bounds-checks
branch
2 times, most recently
from
009ed82
to
ad876df
Compare
In addition to the snapshot.rs changes, this entails adding an entry point function to `bounds-check-image-restrict.wgsl` and `bounds-check-image-rzsw.wgsl`, including appropriate data in the param.ron files.
JCapucho
force-pushed
the
glsl-out-bounds-checks
branch
from
ad876df
to
bb95a93
Compare
jimblandy
approved these changes
May 29, 2022
jimblandy
added a commit
to jimblandy/naga
that referenced
this pull request
Jun 1, 2022
As of gfx-rs#1889, the GLSL back end takes an additional argument specifying the bounds checks policies to use.
jimblandy
added a commit
that referenced
this pull request
Jun 1, 2022
As of #1889, the GLSL back end takes an additional argument specifying the bounds checks policies to use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1887
Implements bounds checks for
ImageLoadon sampled images, because the opengl behavior on invalid texel load and stores for storage images isReadZeroSkipWrite(no bound checks needed).Only works on core for now since es doesn't support samples/levels queries (kvark said in the matrix room that they should be passed in uniforms then)
Closes #1080