Validate ValuePointer exactly like a Pointer to a Scalar.
#1875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teoxoy
approved these changes
Apr 30, 2022
A `ValuePointer` type should always be handled exactly like the equivalent `Pointer` to `Scalar` type. To this end: - Adjust the handling of `TypeFlags::ARGUMENT`. - Neither `Pointer` nor `ValuePointer` types are ever `DATA`.
jimblandy
force-pushed
the
validate-type-value-ptr
branch
from
b573d74
to
d0e2805
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
ValuePointertype should always be handled exactly like the equivalentPointertoScalartype. To this end:Adjust the handling of
TypeFlags::ARGUMENT.Neither
PointernorValuePointertypes are everDATA.