Remove named expression entry for phony assignment #1869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The GLSL frontend is generating some extra expressions that end up being emitted as phony assignments. |
|
The glsl frontend generates a lot of expressions that aren't needed because it's generally easier to do it that way than to add them as needed later, but I do see some weird ones there that I'll need to check out. |
teoxoy
force-pushed
the
phony-not-named-expr
branch
from
0e88c5b
to
859cbac
Compare
kvark
approved these changes
May 10, 2022
teoxoy
force-pushed
the
phony-not-named-expr
branch
from
859cbac
to
be32dcf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1866 (comment)