[spv-out] fix wrong MatrixStride for matCx2 and mat2xR #1781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCapucho
approved these changes
Mar 19, 2022
There was a problem hiding this comment.
It does makes sense to me, but I would like either @kvark or @jimblandy to also have a look since I'm not confident in my understanding of the MatrixStride decoration.
|
There is some more relevant info here: gpuweb/gpuweb#1258 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matrices should have a
MatrixStrideof 8 formatCx2however the current implementation outputs aMatrixStrideof 8 format2xR.