[wgsl-in] implement block comments #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsis1david
changed the title
kvark
reviewed
Jan 19, 2022
src/front/wgsl/lexer.rs
Outdated
| let mut depth = 1; | ||
| while let Some(c) = chars.next() { | ||
| match c { | ||
| '*' if chars.next() == Some('/') => { |
There was a problem hiding this comment.
this will fail on a case like this: /* blabla **/
There was a problem hiding this comment.
hopefully it's fixed, there can be strange cases like /*/**/****/, which is a properly terminated block comment
kocsis1david
force-pushed
the
block-comments
branch
from
4315d79
to
325af95
Compare
kvark
approved these changes
Jan 19, 2022
|
Some tests would be nice to have |
|
And clippy is unhappy |
kocsis1david
force-pushed
the
block-comments
branch
2 times, most recently
from
a2cd31a
to
e507d71
Compare
kocsis1david
force-pushed
the
block-comments
branch
from
e507d71
to
b301ca2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1582
Implement block comments that support nesting.