Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for fma function #1580

Merged
merged 7 commits into from
Dec 22, 2021
Merged

Fixes for fma function #1580

merged 7 commits into from
Dec 22, 2021

Commits on Dec 7, 2021

  1. [hlsl-out] Write mad intrinsic for fma function 

    - This should be enough because we only support f32 for now.
- Adds a new test for WGSL functions, in the spirit of operators.wgsl.
- Closes gfx-rs#1579
    @parasyte
    parasyte committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    beddc71 View commit details
    Browse the repository at this point in the history

  2. Add FMA feature to glsl backend 

    - I think this is right. Just iterate all known expressions in all
  functions and entry points to locate any `fma` function call.
  Should not need to walk the statement DAG.
    @parasyte
    parasyte committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    5cec686 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2021

  1. Transform GLSL fma function into an airthmetic expression when necessary

    @parasyte
    parasyte committed Dec 18, 2021
    Configuration menu
    Copy the full SHA
    df97573 View commit details
    Browse the repository at this point in the history

  2. Add tests for GLSL fma function tranformation

    @parasyte
    parasyte committed Dec 18, 2021
    Configuration menu
    Copy the full SHA
    f4e2416 View commit details
    Browse the repository at this point in the history

  3. Remove the hazard comment from the webgl test input

    @parasyte
    parasyte committed Dec 18, 2021
    Configuration menu
    Copy the full SHA
    7454d1f View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2021

  1. Add helper method for fma function support checks

    @parasyte
    parasyte committed Dec 20, 2021
    Configuration menu
    Copy the full SHA
    4f9addb View commit details
    Browse the repository at this point in the history

  2. Address review comment

    @parasyte
    parasyte committed Dec 20, 2021
    Configuration menu
    Copy the full SHA
    7c8bedc View commit details
    Browse the repository at this point in the history