Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wgsl] Storage buffer/texture access #1142

Merged
merged 10 commits into from
Jul 28, 2021
Merged

[wgsl] Storage buffer/texture access #1142

merged 10 commits into from
Jul 28, 2021

Conversation

525c1e21-bd67-4735-ac99-b4b0e5262290
Copy link
Contributor

@525c1e21-bd67-4735-ac99-b4b0e5262290 525c1e21-bd67-4735-ac99-b4b0e5262290 commented Jul 27, 2021 •
edited by kvark
Loading

TODO

  • HLSL

    • Get proper feedback from someone well-versed in HLSL
    • Formulate failing test for untested code (or remove)

  • SPIRV

    • Ensure OpDecorate %10 NonWritable appearing in tests/out/spv/bounds-check-zero.spvasm is correct

Gordon-F
Gordon-F reviewed Jul 27, 2021
View reviewed changes
src/back/wgsl/writer.rs Outdated Show resolved Hide resolved
Gordon-F
Gordon-F reviewed Jul 27, 2021
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@kvark kvark self-assigned this Jul 27, 2021
@kvark kvark marked this pull request as ready for review July 28, 2021 04:59
@kvark kvark merged commit 2f516c0 into gfx-rs:master Jul 28, 2021
JCapucho pushed a commit to JCapucho/naga that referenced this pull request Aug 1, 2021
@525c1e21-bd67-4735-ac99-b4b0e5262290 @kvark @JCapucho
[wgsl] Storage buffer/texture access (gfx-rs#1142)
de0647a 
* Resurrect texture_storage_* tests
* Test parsing of `var<storage,write>`
* Default storage textures to READ
* Restore default features
* Fix glsl/hlsl/msl/spv front and back ends
* Add missing test outputs
* All-around fixes for the storage access

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
@kvark kvark mentioned this pull request Aug 5, 2021
Merged
@kvark kvark mentioned this pull request Aug 16, 2021
Merged
@kvark kvark mentioned this pull request Aug 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gordon-F Gordon-F Gordon-F left review comments

Assignees

@kvark kvark

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@525c1e21-bd67-4735-ac99-b4b0e5262290 @Gordon-F @kvark